Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children and Member tabs show up regardless of edit permission #109

Open
bseeger opened this issue Apr 7, 2021 · 3 comments
Open

Children and Member tabs show up regardless of edit permission #109

bseeger opened this issue Apr 7, 2021 · 3 comments
Labels
access controls bug Something isn't working nice-to-have-for-launch wontfix This will not be worked on

Comments

@bseeger
Copy link

bseeger commented Apr 7, 2021

In fixing #35, it sort of creates another issue, because of #107.

The "Children" and "Media" tabs each have a button ("Add child", "Add media") to add new nodes or media. The buttons show up regardless of whether or not a user has permission to add Media or Children to that collection. The logic for these tabs is in Islandora module and we may want to override how they work, so they don't show up if the user doesn't have edit access to the parent object.

Because of #107, it makes it easier for a user who shouldn't be able to to add children to a collection. (The access terms field works just fine, btw, as it filters out options the user doesn't have access to. In other words, the user cannot give the new node any access terms they do not have access to).

@bseeger bseeger added bug Something isn't working access controls labels Apr 7, 2021
@bseeger
Copy link
Author

bseeger commented Apr 7, 2021

Note that this is due to the logic for the tabs being in the Islandora module and the logic for access controls being in Workbench Access. It's just that they are disjoint and can be reconciled.

@htpvu htpvu added the vendor label Apr 12, 2021
@bseeger bseeger changed the title Children and Member tabs show up regarless of edit permission Children and Member tabs show up regardless of edit permission Apr 20, 2021
@birkland
Copy link

This is admin-facing, may be candidate to defer to after launch, or not fix at all

@htpvu htpvu added the wontfix This will not be worked on label Mar 4, 2022
@htpvu
Copy link

htpvu commented Mar 4, 2022

Per Aaron's comment, we wont fix this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
access controls bug Something isn't working nice-to-have-for-launch wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants