Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: use <iframe> as redirect mechanism #122

Open
dbkaplun opened this issue Jun 26, 2016 · 4 comments
Open

Feature: use <iframe> as redirect mechanism #122

dbkaplun opened this issue Jun 26, 2016 · 4 comments

Comments

@dbkaplun
Copy link

dbkaplun commented Jun 26, 2016

This would also fix #113 and #114 as the address bar does not update when an <iframe>'s src changes.

New UI:
iframe

Current master for comparison:
master

List of options (let me know if you want different copy):
options

dbkaplun added a commit to dbkaplun/NewTab-Redirect that referenced this issue Jun 26, 2016
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox
Deprecate 'always-tab-update' option, replace with 'redirectMechanism'

Closes jimschubert#122
dbkaplun added a commit to dbkaplun/NewTab-Redirect that referenced this issue Jun 26, 2016
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox
Deprecate 'always-tab-update' option, replace with 'redirectMechanism'

Closes jimschubert#122
dbkaplun added a commit to dbkaplun/NewTab-Redirect that referenced this issue Jun 26, 2016
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox
Deprecate 'always-tab-update' option, replace with 'redirectMechanism'

Closes jimschubert#122
dbkaplun added a commit to dbkaplun/NewTab-Redirect that referenced this issue Jun 26, 2016
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox
Deprecate 'always-tab-update' option, replace with 'redirectMechanism'

Closes jimschubert#122
dbkaplun added a commit to dbkaplun/NewTab-Redirect that referenced this issue Jun 26, 2016
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox
Deprecate 'always-tab-update' option, replace with 'redirectMechanism'

Closes jimschubert#122
dbkaplun added a commit to dbkaplun/NewTab-Redirect that referenced this issue Jun 27, 2016
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox
Deprecate 'always-tab-update' option, replace with 'redirectMechanism'

Closes jimschubert#122
dbkaplun added a commit to dbkaplun/NewTab-Redirect that referenced this issue Aug 8, 2016
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox
Deprecate 'always-tab-update' option, replace with 'redirectMechanism'

Closes jimschubert#122
@dbkaplun
Copy link
Author

dbkaplun commented Aug 8, 2016

@jimschubert added screenshots above, please review. Changed the option text to warn about potential security issues. Been using it for a month or so. People could really find this option useful!

@jimschubert
Copy link
Owner

Thanks for the PR, but as I mentioned this isn't something I'm comfortable adding for multiple reasons:

  1. It poses a security risk for which I would potentially be liable
  2. It removes standard web behavior
  3. I'm fairly certain it violates Chrome Extension agreements
  4. (the main one) I am the one that has to answer emails when users ignore things like "potentially insecure" or "power users only". Then, there are users that see things like "potentially insecure" and think it applies to the entire extension. I don't really have time for that.

If you'd like to fork the project and re-release it with the idea me mechanism, I could assist.

@jimschubert
Copy link
Owner

Er, iframe mechanism. Mobile github doesn't allow editing.

@dbkaplun
Copy link
Author

dbkaplun commented Aug 25, 2016

You think people will not be swayed by the warning in the option text? Honestly I think most of those concerns are not too scary but I will change the copy if you're not happy with it. I am using the code in this PR in my Chrome so it would be great if it gets merged but it seems like there is some desire for such a feature so it might be worth it to have this added.

@dbkaplun dbkaplun changed the title Feature request: use <iframe> as redirect mechanism Feature: use <iframe> as redirect mechanism May 4, 2018
@jimschubert jimschubert pinned this issue Nov 24, 2020
Repository owner locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants