-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: use <iframe> as redirect mechanism #122
Comments
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox Deprecate 'always-tab-update' option, replace with 'redirectMechanism' Closes jimschubert#122
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox Deprecate 'always-tab-update' option, replace with 'redirectMechanism' Closes jimschubert#122
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox Deprecate 'always-tab-update' option, replace with 'redirectMechanism' Closes jimschubert#122
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox Deprecate 'always-tab-update' option, replace with 'redirectMechanism' Closes jimschubert#122
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox Deprecate 'always-tab-update' option, replace with 'redirectMechanism' Closes jimschubert#122
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox Deprecate 'always-tab-update' option, replace with 'redirectMechanism' Closes jimschubert#122
Add "Redirect mechanism" <select> that replaces "always update tab" checkbox Deprecate 'always-tab-update' option, replace with 'redirectMechanism' Closes jimschubert#122
@jimschubert added screenshots above, please review. Changed the option text to warn about potential security issues. Been using it for a month or so. People could really find this option useful! |
Thanks for the PR, but as I mentioned this isn't something I'm comfortable adding for multiple reasons:
If you'd like to fork the project and re-release it with the idea me mechanism, I could assist. |
Er, iframe mechanism. Mobile github doesn't allow editing. |
You think people will not be swayed by the warning in the option text? Honestly I think most of those concerns are not too scary but I will change the copy if you're not happy with it. I am using the code in this PR in my Chrome so it would be great if it gets merged but it seems like there is some desire for such a feature so it might be worth it to have this added. |
This would also fix #113 and #114 as the address bar does not update when an <iframe>'s src changes.
New UI:
![iframe](https://cloud.githubusercontent.com/assets/1765130/17469660/2cabd2ee-5cea-11e6-95ff-1596088f823d.png)
Current master for comparison:
![master](https://cloud.githubusercontent.com/assets/1765130/17469661/2cbfb73c-5cea-11e6-86d6-e31383d11a87.png)
List of options (let me know if you want different copy):
![options](https://cloud.githubusercontent.com/assets/1765130/17469662/2cc88fd8-5cea-11e6-9b20-1fe90c53664e.png)
The text was updated successfully, but these errors were encountered: