Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boolean operations doesnt consistently simplify lines #106

Open
jimy-byerley opened this issue May 9, 2024 · 1 comment
Open

boolean operations doesnt consistently simplify lines #106

jimy-byerley opened this issue May 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jimy-byerley
Copy link
Owner

Currently this is visible on the flat screw heads

image

the call to line_simplification in cut_mesh does not seem to return the same simplification on both sides
@jimy-byerley jimy-byerley added the bug Something isn't working label May 9, 2024
@jimy-byerley
Copy link
Owner Author

In this case, this is caused by flat triangles coming the from revolution generating the top circular surface. The ngons selections are stopping to flat triangles in the current boolean operations implementation.

This will be fixed by #107 first, but it could be good to make the the ngon selection robust to flat triangles anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimy-byerley