Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSEloss by default uses 'mean' as reduction method #13

Open
akiori opened this issue Nov 15, 2022 · 1 comment
Open

MSEloss by default uses 'mean' as reduction method #13

akiori opened this issue Nov 15, 2022 · 1 comment

Comments

@akiori
Copy link

akiori commented Nov 15, 2022

MSEloss by default uses 'mean' as reduction method, so I think epoch_loss += (loss.detach().item() / batchsize) is incorrect

@Alex-177
Copy link

I came in to write the same thing.
Besides, now the loss is accumulating on every butch. More precisely, the loss / batchsize value is accumulated.
It seems to me more logical to output the loss value on the last batch of training.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants