Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jigasi readiness/liveness probes do not use the health check endpoints #146

Open
XenonPK opened this issue Nov 21, 2024 · 1 comment
Open

Comments

@XenonPK
Copy link
Contributor

XenonPK commented Nov 21, 2024

Hello,

When using this helm chart with jigasi support enabled, I noticed, that the container's readiness/liveness probes are simple tcp probes, instead of using the health check path provided by jigasi.

I would like to propose switching to using a http probe on port 8788, and path /about/health, at least for the liveness probes.

The advantages of this approach are:

  • The jigasi component would be able to automatically recover from failure without human intervention, in situations where connectivity to the underlying SIP gateway fails temporarily.
@at-platform24
Copy link
Contributor

at-platform24 commented Nov 28, 2024

jitsi-helm/values.yaml

Lines 328 to 333 in 8f9235c

livenessProbe:
tcpSocket:
port: 8788
readinessProbe:
tcpSocket:
port: 8788
can be updated to change the default. @XenonPK , would you like to create a PR?
As of now it should obviously be possible to override these values.

Also, might be a good idea to add startup probe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants