Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting 'call-integration.enabled' value to true makes impossible to play video when shared via youtube link #14812

Open
1 of 11 tasks
mdhanif-simformsolutions opened this issue Jun 7, 2024 · 5 comments

Comments

@mdhanif-simformsolutions
Copy link

mdhanif-simformsolutions commented Jun 7, 2024

Hi,

I've installed Jitsi demo app from :- https://github.com/jitsi/jitsi-meet-sdk-samples

In the code :-

MainActivity File

val defaultOptions = JitsiMeetConferenceOptions.Builder()
                .setServerURL(serverURL)
                // When using JaaS, set the obtained JWT here
                //.setToken("MyJWT")
                // Different features flags can be set
                //.setFeatureFlag("toolbox.enabled", false)
                //.setFeatureFlag("filmstrip.enabled", false)
                .setFeatureFlag("call-integration.enabled", true).  // Add this flag and set to true
                .build()
        JitsiMeet.setDefaultConferenceOptions(defaultOptions)

If I add .setFeatureFlag("call-integration.enabled", true) at any place it makes impossible to play video when shared via youtube url.

This happens in Jitsi sample demo as well.

Although this is not mentioned in the description of the given feature flag which makes it confusing.

Platform

  • Chrome (or Chromium based)
  • Firefox
  • Safari
  • Other desktop browser
  • Android browser
  • iOS browser
  • Electron app
  • Android mobile app
  • iOS mobile app
  • Custom app using a mobile SDK

Browser / app / sdk version

9.2.2

Relevant log output

No response

Reproducibility

  • The problem is reproducible on meet.jit.si

More details?

No response

@saghul
Copy link
Member

saghul commented Jun 7, 2024

We ran into many problems with ConnectionService, that's why it's off by default :-( I wasn't aware of this one though...

@mdhanif-simformsolutions
Copy link
Author

Screenshot 2024-06-07 at 8 00 06 PM

Still documentation shows it ON by default

Should probably update that as well

@saghul
Copy link
Member

saghul commented Jun 7, 2024

Good point!

@mdhanif-simformsolutions
Copy link
Author

Do you think this can be fixed ? We need this feature enable for all platforms and not run into this kind of issues ?

@saghul
Copy link
Member

saghul commented Jun 7, 2024

I don't know how, but if you figure it out, a PR would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants