Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Welcome Page Image #14842

Open
Ronald-Agorsah opened this issue Jun 18, 2024 · 6 comments
Open

Custom Welcome Page Image #14842

Ronald-Agorsah opened this issue Jun 18, 2024 · 6 comments
Labels
feature-request Issue which suggest an idea, enhancement or feature to implement

Comments

@Ronald-Agorsah
Copy link

What problem are you trying to solve?

Missing css/all.css when running make source-package

Description:
I am trying to build a source package for Jitsi Meet using the make source-package command, but I am encountering an error stating that the css/all.css file is missing. Here are the steps I followed and the issues I encountered:

Steps to Reproduce:

  1. Cloned the repository and navigated to the project directory:
    git clone https://github.com/jitsi/jitsi-meet.git
    cd jitsi-meet
  2. Created the libs directory to resolve an earlier error:
    mkdir -p libs
  3. Installed dependencies:
    npm install
  4. Attempted to create the source package:
    make source-package

Error Message:

cp: cannot stat 'css/all.css': No such file or directory
make: *** [Makefile:126: source-package] Error 1

Expected Behavior:
The make source-package command should create a source package without errors, including the css/all.css file.

Actual Behavior:
The process fails with the error message that the css/all.css file is missing.

Additional Information:

  • Node version: v18.19.0
  • npm version: 9.2.0

Troubleshooting Steps Taken:

  1. Verified that the css/all.css file is indeed missing.
  2. Ran npm install to ensure all dependencies were installed.
  3. Checked the package.json for build scripts related to CSS generation but could not find any specific reference to generating all.css.

Questions/Requests:

  1. Is there a specific build step I am missing to generate the css/all.css file?
  2. Could the documentation be updated to include any additional build steps required for generating this file?

Any help would be greatly appreciated.

What solution would you like to see?

No response

Is there an alternative?

No response

@Ronald-Agorsah Ronald-Agorsah added the feature-request Issue which suggest an idea, enhancement or feature to implement label Jun 18, 2024
@Ronald-Agorsah Ronald-Agorsah changed the title Custom Welcome Page image Custom Welcome Page Image Jun 18, 2024
@damencho
Copy link
Member

Execute first make. make source-package expects you have already built the app via make.

@damencho
Copy link
Member

Building the sources documentation mentions you need npm install and then make.

https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-web-jitsi-meet#building-the-sources

@Ronald-Agorsah
Copy link
Author

Ronald-Agorsah commented Jun 18, 2024

Hi there,

I followed these steps to build the Jitsi Meet application:

Cloned the repository:

bash

git clone https://github.com/jitsi/jitsi-meet
cd ./jitsi-meet

Installed dependencies using npm:

npm install

Built the Jitsi Meet application using make:

go

make

However, I'm encountering an issue where the all.css file is missing in /usr/share/jitsi-meet/ after running make. It's crucial for the application's functionality, and despite checking the build process, the file is not being copied over.

I've reviewed the Makefile and ensured that the build commands are executing correctly. The directory structure appears intact, but all.css doesn't seem to be included in the final build output.

Could you please advise on any additional steps or configurations needed to ensure that all.css is properly included in /usr/share/jitsi-meet/ during the build process?

For further assistance, I can provide more details about my environment and any specific logs or error messages encountered during the build.

Thank you!

Best regards,

@damencho
Copy link
Member

However, I'm encountering an issue where the all.css file is missing in /usr/share/jitsi-meet/ after running make.

The files in /usr/share are coming from the debian package. You are building sources, not a debian package.

The all.css file you should see in css/all.css in your source folder after make finishes successfully.

If you want to build the debian package follow the steps in the guide that I already shared.

https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-web-jitsi-meet#building-debs

@damencho
Copy link
Member

If you just want to test your changes there is no need to build debian package and install it. Look at the last section of the developer guide for how you can test your changes.

Make sure you keep your changes isolates so you can do regular updates as many things change and you need to keep up with browser changes which happen every month.

@Ronald-Agorsah
Copy link
Author

Hello,

I am trying to deploy Jitsi Meet using Docker as per the recommended setup steps. I downloaded the latest release package, configured the environment, and created the necessary directories. However, after running the containers, I noticed that certain assets, such as jitsilogo.png, are not present in the expected locations inside the Docker containers.

Here are the steps I followed:

Downloaded and extracted the latest release:

sh

wget $(curl -s https://api.github.com/repos/jitsi/docker-jitsi-meet/releases/latest | grep 'zip' | cut -d" -f4)
unzip

Created the .env file and set up strong passwords:

sh

cp env.example .env
./gen-passwords.sh

Created the required CONFIG directories:

sh

mkdir -p ~/.jitsi-meet-cfg/{web,transcripts,prosody/config,prosody/prosody-plugins-custom,jicofo,jvb,jigasi,jibri}

Started the Docker environment:

sh

docker compose up -d

Verified the presence of jitsilogo.png and other assets using grep:

sh

grep -r 'jitsilogo.png' /root/
/root/jitsi-meet/title.html:<meta property="og:image" content="images/jitsilogo.png?v=1"/>
/root/jitsi-meet/title.html:<meta itemprop="image" content="images/jitsilogo.png?v=1"/>
grep: /root/jitsi-meet/.git/index: binary file matches

Steps to Reproduce:

Download and extract the latest release package.
Create the .env file and set strong passwords.
Create the required CONFIG directories.
Start the Docker containers.
Access the running Docker container:

sh

docker exec -it <container_id> /bin/bash

Check for the presence of jitsilogo.png:

sh

ls /path/to/images/jitsilogo.png

Expected Behavior:

The jitsilogo.png and other assets should be present in their respective directories inside the Host or should they be in the Docker container, as they are in the local repository?

thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Issue which suggest an idea, enhancement or feature to implement
Projects
None yet
Development

No branches or pull requests

2 participants