rotor: don't put fetch logs to errors collection

absorbb · absorbb · commit ec2c41f3f3f7 · 2023-12-20T13:11:49.000+04:00
diff --git a/libs/core-functions/src/context.ts b/libs/core-functions/src/context.ts
@@ -54,14 +54,14 @@ export function createFullContext(
           err.message = `Fetch request exceeded timeout ${timeout}ms and was aborted`;
         }
         if (logToRedis) {
-          eventsStore.log(connectionId, true, { ...baseInfo, error: getErrorMessage(err), elapsedMs: sw.elapsedMs() });
+          eventsStore.log(connectionId, false, { ...baseInfo, error: getErrorMessage(err), elapsedMs: sw.elapsedMs() });
         }
         throw err;
       }
       //clone response to be able to read it twice
       const cloned = fetchResult.clone();
       if (logToRedis) {
-        eventsStore.log(connectionId, !fetchResult.ok, {
+        eventsStore.log(connectionId, false, {
           ...baseInfo,
           status: fetchResult.status,
           statusText: fetchResult.statusText,

Original file line number	Diff line number	Diff line change
`@@ -54,14 +54,14 @@ export function createFullContext(`
`54`	`54`	err.message = `Fetch request exceeded timeout ${timeout}ms and was aborted`;
`55`	`55`	`}`
`56`	`56`	`if (logToRedis) {`
`57`		`- eventsStore.log(connectionId, true, { ...baseInfo, error: getErrorMessage(err), elapsedMs: sw.elapsedMs() });`
	`57`	`+ eventsStore.log(connectionId, false, { ...baseInfo, error: getErrorMessage(err), elapsedMs: sw.elapsedMs() });`
`58`	`58`	`}`
`59`	`59`	`throw err;`
`60`	`60`	`}`
`61`	`61`	`//clone response to be able to read it twice`
`62`	`62`	`const cloned = fetchResult.clone();`
`63`	`63`	`if (logToRedis) {`
`64`		`- eventsStore.log(connectionId, !fetchResult.ok, {`
	`64`	`+ eventsStore.log(connectionId, false, {`
`65`	`65`	`...baseInfo,`
`66`	`66`	`status: fetchResult.status,`
`67`	`67`	`statusText: fetchResult.statusText,`