jj bookmark create allows creating unreferenceable bookmarks

[zx8]

Using 514a009

---

Repro:

$ jj bookmark create foo:bar
Warning: Failed to export some bookmarks:
  foo:bar: Failed to set: A reference must be a valid tag name as well: A ref must not
  contain invalid bytes or ascii control characters: ":"

At this point, the bookmark is still created, despite the error:

○  yxlrwnxw [email protected] 2025-02-14 15:54:52 foo:bar 7d98d8bc
│  (empty) (no description set)

If I try to reference that bookmark, it does not work:

$ jj show foo:bar
Error: Failed to parse revset: Modifier `foo` doesn't exist
Caused by:  --> 1:1
  |
1 | foo:bar
  | ^-^
  |
  = Modifier `foo` doesn't exist

If I try to delete the bookmark:

$ jj bookmark delete foo:bar
error: invalid value 'foo:bar' for '<NAMES>...': Invalid string pattern kind `foo:`

If I use exact:foo:bar, it does work.

[PhilipMetzger]

this will be fixed by #5423 where we make bookmark creation stricter.