Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make v1 available on Window #37

Closed
jkfran opened this issue May 20, 2024 · 4 comments · Fixed by #38
Closed

Make v1 available on Window #37

jkfran opened this issue May 20, 2024 · 4 comments · Fixed by #38

Comments

@jkfran
Copy link
Owner

jkfran commented May 20, 2024

Perform needed changes on windows.rs to release v1 on it.

Update release action:

# - x86_64-pc-windows-gnu

@masoncfrancis
Copy link

Literally came here to make this issue. Would love to have v1 available for windows

@jkfran
Copy link
Owner Author

jkfran commented May 21, 2024

Last contributor to help with the Windows release was @jacobtread. I really hope he can have a look into the changes made to release a v1 for Windows. 🙏🏼

@jacobtread
Copy link
Contributor

Happy to give it a look tomorrow at around 6pm NZST needed something to write so ill get onto it

@jacobtread
Copy link
Contributor

Had a chance to give it some work tonight, draft PR is at #38 got it working and all. Just want to put some polish and final touches on it tomorrow and should be good to go

Only made slight modifications to the mac and linux version (Had to untangle some of the unix specific code thats made it's way into the platform neutral files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants