Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare @ember/string as peerDependency #409

Closed
mkszepp opened this issue Jun 12, 2024 · 2 comments · Fixed by #411
Closed

Declare @ember/string as peerDependency #409

mkszepp opened this issue Jun 12, 2024 · 2 comments · Fixed by #411

Comments

@mkszepp
Copy link

mkszepp commented Jun 12, 2024

The addon is using @ember/string, but there is not declared as peerDependency.

import { modifier } from 'ember-modifier';
import ClipboardJS from 'clipboard';
import { isBlank } from '@ember/utils';
import { capitalize } from '@ember/string';
import { guidFor } from '@ember/object/internals';
import { macroCondition, dependencySatisfies } from '@embroider/macros';

@elwayman02
Copy link

I'm seeing Webpack throw test errors due to this issue:

message: ember-cli-clipboard tried to import "@ember/string" in "ember-cli-clipboard/modifiers/clipboard.js" from addon code, but "@ember/string" is a devDependency. You may need to move it into dependencies.

This occurs when bumping @ember/string from v3 to v4, likely because it's now a real module which requires ember-auto-import/embroider to consume. See also: emberjs/ember-string#425

@jkusa
Copy link
Owner

jkusa commented Jul 20, 2024

Update for this now available in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants