after talking with Antonio, we decided that no additional config parameter for ENABLE_HTTPS_PLUGIN_FILETRANSFER is necessary, we simply expose these new endpoints, whatever

Author: sjanssen2

.github/workflows/qiita-ci.yml

@@ -58,9 +58,6 @@ jobs:
           pgport=${{ job.services.postgres.ports[5432] }}
           sed -i "s/PORT = 5432/PORT = $pgport/" qiita_core/support_files/config_test.cfg
 
-          # enable endpoints for HTTPS file transfer from/to plugin(s) and qiita main
-          sed -i "s/ENABLE_HTTPS_PLUGIN_FILETRANSFER = False/ENABLE_HTTPS_PLUGIN_FILETRANSFER = True/" qiita_core/support_files/config_test.cfg
-
           # PGPASSWORD is read by pg_restore, which is called by the build_db process.
           export PGPASSWORD=postgres
 

qiita_core/configuration_manager.py

@@ -123,12 +123,6 @@ class ConfigurationManager(object):
         The script used to start the plugins
     plugin_dir : str
         The path to the directory containing the plugin configuration files
-    enable_https_plugin_filetransfer : bool
-        Allow BASE_DATA_DIR file content transfer through https (True or False)
-        By default, Qiita and its plugins share the filesystem of
-        BASE_DATA_DIR. You can less tightly couple selected plugins
-        (=no shared file system) but they need to get/push input/output files
-        through https then
     help_email : str
         The email address a user should write to when asking for help
     sysadmin_email : str
@@ -221,8 +215,6 @@ def _get_main(self, config):
         elif not isdir(self.plugin_dir):
             raise ValueError("The PLUGIN_DIR (%s) folder doesn't exist"
                              % self.plugin_dir)
-        self.enable_https_plugin_filetransfer = config.getboolean(
-            'main', 'ENABLE_HTTPS_PLUGIN_FILETRANSFER', fallback=False)
 
         self.valid_upload_extension = [ve.strip() for ve in config.get(
             'main', 'VALID_UPLOAD_EXTENSION').split(',')]

qiita_core/tests/test_configuration_manager.py

@@ -55,7 +55,6 @@ def test_init(self):
         self.assertEqual(
             obs.valid_upload_extension,
             ["fastq", "fastq.gz", "txt", "tsv", "sff", "fna", "qual"])
-        self.assertEqual(obs.enable_https_plugin_filetransfer, False)
         self.assertEqual(obs.certificate_file, "/tmp/server.cert")
         self.assertEqual(obs.cookie_secret, "SECRET")
         self.assertEqual(obs.key_file, "/tmp/server.key")
@@ -332,12 +331,6 @@ def test_get_portal_latlong(self):
 # Plugins configuration directory
 PLUGIN_DIR = /tmp/
 
-# Allow BASE_DATA_DIR file content transfer through https (True or False)
-# By default, Qiita and its plugins share the filesystem of BASE_DATA_DIR.
-# You can less tightly couple selected plugins (=no shared file system) but
-# they need to get/push input/output files through https then
-ENABLE_HTTPS_PLUGIN_FILETRANSFER = False
-
 # Webserver certificate file paths
 CERTIFICATE_FILE = /tmp/server.cert
 KEY_FILE = /tmp/server.key

qiita_pet/webserver.py

@@ -248,8 +248,7 @@ def __init__(self):
         # expose endpoints necessary for https file communication between
         # master and plugins IF no shared file system for base_data_dir is
         # intended
-        if qiita_config.enable_https_plugin_filetransfer:
-            handlers.extend(CLOUD_ENDPOINTS)
+        handlers.extend(CLOUD_ENDPOINTS)
 
         # rest endpoints
         handlers.extend(REST_ENDPOINTS)