Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if you have optimization on and write rows in the wrong order #174

Open
neilb opened this issue Sep 29, 2016 · 2 comments
Open

Warn if you have optimization on and write rows in the wrong order #174

neilb opened this issue Sep 29, 2016 · 2 comments

Comments

@neilb
Copy link
Contributor

neilb commented Sep 29, 2016

If a workbook has optimization enabled, you could generate a warning if rows are written to out of order.

On a related note, I plan to submit a PR to update the documentation in a couple of places :-)
I'll do that as one of my Hacktoberfest PRs!

Cheers,
Neil

@jmcnamara
Copy link
Owner

If a workbook has optimization enabled, you could generate a warning if rows are written to out of order.

Perhaps. This behaviour is documented and I've had very few issues reported around this. The documentation on this "feature" could probably be improved a bit. I did that recently for the Python version of the module.

I'll keep it in mind though.

On a related note, I plan to submit a PR to update the documentation in a couple of places :-)
I'll do that as one of my Hacktoberfest PRs!

Yes. Please do. :-)

@neilb
Copy link
Contributor Author

neilb commented Sep 29, 2016

This behaviour is documented and I've had very few issues reported around this

Please consider this one such report :-)

We switched from XLS to XLSX, and I didn't notice at the time that some headers (easy to calculate after processing all rows) were no longer showing. They were all merged headers, which slightly led me down the wrong path. I read various bits of the doc, and spent well over an hour trying to work out what the heck was going on.

Eventually I trawled through the close github issues, and that's where I found the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants