Skip to content

Commit af8f360

Browse files
PR: add bump ver check (be5invis#2282)
* Add bump-version check into the PR validation workflow * Check condition for PR * Setup step and job outputs for conditionals * Fixup * Limit fetch depth * Fix typo * Use a different checkout pattern * Bump version * Fixup conditional for the build stage * Still allow the build stage even if the bump_version_check stage did found changes, as commits by github actions bot won't triggger actions --------- Co-authored-by: GitHub Actions <[email protected]>
1 parent e866ee9 commit af8f360

File tree

20 files changed

+224
-173
lines changed

20 files changed

+224
-173
lines changed

.github/workflows/pr-build-validation.yml

+52-1
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,61 @@ name: PR Font Build Validation
33
on: [pull_request]
44

55
jobs:
6+
bump_version_check:
7+
name: Bump version check
8+
if: github.repository == 'be5invis/Iosevka' && github.base_ref == 'dev'
9+
runs-on: ubuntu-latest
10+
11+
outputs:
12+
changed: ${{ steps.check_changes.outputs.changed }}
13+
14+
steps:
15+
- name: Checkout PR
16+
uses: actions/checkout@v4
17+
with:
18+
ref: ${{ github.event.pull_request.head.ref }}
19+
20+
- name: Use Node.js
21+
uses: actions/setup-node@v4
22+
with:
23+
node-version: lts/*
24+
25+
- name: Bump version
26+
run: |
27+
npm install
28+
npm run bump-ver
29+
30+
- id: check_changes
31+
name: Check changes
32+
run: |
33+
git config core.autocrlf false
34+
if git diff --quiet; then
35+
echo "changed=0" >> "$GITHUB_OUTPUT"
36+
else
37+
echo "changed=1" >> "$GITHUB_OUTPUT"
38+
fi
39+
40+
- name: Commit to PR
41+
if: steps.check_changes.outputs.changed == '1'
42+
run: |
43+
git config --local user.email "[email protected]"
44+
git config --local user.name "GitHub Actions"
45+
git add --all
46+
git commit -m "Bump version"
47+
git push
48+
49+
- name: Add PR comment
50+
uses: mshick/add-pr-comment@v2
51+
if : steps.check_changes.outputs.changed == '1'
52+
with:
53+
message: |
54+
Your pull request changes the version number.
55+
A commit has been made to bump the version number.
56+
657
build:
758
name: Build ${{ matrix.fontName }} font
59+
needs: bump_version_check
860
if: github.repository == 'be5invis/Iosevka'
9-
1061
runs-on: ubuntu-latest
1162

1263
strategy:

changes/archives/28.x/28.0.4.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
* Fix leaning marks of turned capital F/L (#2137).
2-
* Fix overlay bar placement of Z with Hook and Z with Swash Tail (#2141).
3-
* Fix attachment of descender parts of Cyrillic Lower Ha/X under `x` = `cursive` (#2142).
4-
* Make the Eng part in LATIN SMALL LETTER FENG DIGRAPH always connected to the f part (#2143).
5-
* Fix top bar shape in CYRILLIC CAPITAL LETTER DJE (#2145).
6-
* Fix leaning marks placement for reversed k/F/P (#2150).
1+
* Fix leaning marks of turned capital F/L (#2137).
2+
* Fix overlay bar placement of Z with Hook and Z with Swash Tail (#2141).
3+
* Fix attachment of descender parts of Cyrillic Lower Ha/X under `x` = `cursive` (#2142).
4+
* Make the Eng part in LATIN SMALL LETTER FENG DIGRAPH always connected to the f part (#2143).
5+
* Fix top bar shape in CYRILLIC CAPITAL LETTER DJE (#2145).
6+
* Fix leaning marks placement for reversed k/F/P (#2150).

changes/archives/5.x/5.0.6.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
* Fix incorrect serif shape for motion-serifed `m` under semi-proportional subfamilies.
2-
* Add cursive variant for `x` and `z` (#852).
3-
* Slab will now use more cursive variants for `k`, `x` and `z`.
1+
* Fix incorrect serif shape for motion-serifed `m` under semi-proportional subfamilies.
2+
* Add cursive variant for `x` and `z` (#852).
3+
* Slab will now use more cursive variants for `k`, `x` and `z`.
44
* `ss15` and `ss17` are updated to use latest cursive variants (#852).

doc/BackersArchive.md

+36-36
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,36 @@
1-
# Backers Archive
2-
3-
This is an archive of former backers that sponsored Iosevka’s development during 0.x–2.x period. Iosevka will continue evolving, and thank you for your support.
4-
5-
## Generous Backers
6-
7-
- Cheng-Wei Chien
8-
- Tianyu Ge
9-
- (Anonymous User 4362976)
10-
- Delton Ding
11-
- Codi Matters
12-
- Vasily Shmelev
13-
14-
## Backers
15-
16-
- Danny O'Brien
17-
- Yanjia Huang
18-
- Leon Breedt
19-
- Alexander Payne
20-
- Marek Kubica
21-
- Yoshito Komatsu
22-
- Dylan Sinnott
23-
- robertgzr
24-
- Pavlos Vinieratos
25-
- Matthew Piziak
26-
- Winnie Quinn
27-
- Clemens
28-
- Pascal
29-
- Kevin Sidarous
30-
- Beni Cherniavsky-Paskin
31-
- Bartłomiej T. Listwon
32-
- Will Binns-Smith
33-
- Jeff S
34-
- Jeri Mason
35-
- Michael L. Ward
36-
- Freetasy
1+
# Backers Archive
2+
3+
This is an archive of former backers that sponsored Iosevka’s development during 0.x–2.x period. Iosevka will continue evolving, and thank you for your support.
4+
5+
## Generous Backers
6+
7+
- Cheng-Wei Chien
8+
- Tianyu Ge
9+
- (Anonymous User 4362976)
10+
- Delton Ding
11+
- Codi Matters
12+
- Vasily Shmelev
13+
14+
## Backers
15+
16+
- Danny O'Brien
17+
- Yanjia Huang
18+
- Leon Breedt
19+
- Alexander Payne
20+
- Marek Kubica
21+
- Yoshito Komatsu
22+
- Dylan Sinnott
23+
- robertgzr
24+
- Pavlos Vinieratos
25+
- Matthew Piziak
26+
- Winnie Quinn
27+
- Clemens
28+
- Pascal
29+
- Kevin Sidarous
30+
- Beni Cherniavsky-Paskin
31+
- Bartłomiej T. Listwon
32+
- Will Binns-Smith
33+
- Jeff S
34+
- Jeri Mason
35+
- Michael L. Ward
36+
- Freetasy

docker/README.md

+48-48
Original file line numberDiff line numberDiff line change
@@ -1,48 +1,48 @@
1-
## Make docker image
2-
```
3-
git clone --depth=1 https://github.com/be5invis/Iosevka.git $HOME/mkdkimg
4-
cd $HOME/mkdkimg/docker
5-
docker build -t=fontcc .
6-
docker images | grep fontcc # Confirm that the docker image is generated successfully
7-
fontcc latest c847d5e08886 About a minute ago 491MB
8-
cd ../..
9-
rm -rf mkdkimg/
10-
```
11-
Note: Make docker image need execute only one time.
12-
13-
## Usage
14-
`docker run -it --rm -v $PWD:/work fontcc <BUILD_ARGS>`
15-
Please refer to the `<BUILD_ARGS>` parameters to [Customized Build](../../dev/doc/custom-build.md#customized-build)
16-
### Optional parameters (put them before `fontcc`):
17-
1. `-e "VERSION_TAG=<tag>"`
18-
19-
`<tag>` can be the following values
20-
- `main` git main branch
21-
- `dev` git dev branch
22-
- `v28.0.5` git [release version tags](../../../tags)
23-
24-
When this variable is omitted, the tag of the latest release will be selected
25-
26-
2. `-e "NPM_REG=<npm repository mirror url>"`
27-
28-
change `npm install` download repository to mirror site.
29-
30-
eg. change npm repos to huawei mirror
31-
`docker run -it --rm -v $PWD:/work -e "NPM_REG=https://mirrors.huaweicloud.com/repository/npm" fontcc contents::Iosevka`
32-
33-
## Example
34-
### Partially Build dev branch
35-
```
36-
mkdir -p $HOME/build_fonts
37-
cd $HOME/build_fonts
38-
docker run -it --rm -v $PWD:/work -e "VERSION_TAG=dev" fontcc contents::IosevkaSS06 ttf::IosevkaSS12 webfont::IosevkaSS15
39-
ls -lR dist/
40-
```
41-
### Customized Build
42-
```
43-
cd $HOME/mycustomfonts
44-
cat myfont1.toml myfont2.toml myfont3.toml > private-build-plans.toml
45-
docker run -it --rm -v $PWD:/work fontcc ttf::myfont1 ttf::myfont2 contents::myfont3
46-
ls -lR dist/
47-
```
48-
Note: You need prepare myfont1.toml myfont2.toml myfont3.toml youself, The [Customizer](https://be5invis.github.io/Iosevka/customizer) can help you easily generate font configuration file `.toml`.
1+
## Make docker image
2+
```
3+
git clone --depth=1 https://github.com/be5invis/Iosevka.git $HOME/mkdkimg
4+
cd $HOME/mkdkimg/docker
5+
docker build -t=fontcc .
6+
docker images | grep fontcc # Confirm that the docker image is generated successfully
7+
fontcc latest c847d5e08886 About a minute ago 491MB
8+
cd ../..
9+
rm -rf mkdkimg/
10+
```
11+
Note: Make docker image need execute only one time.
12+
13+
## Usage
14+
`docker run -it --rm -v $PWD:/work fontcc <BUILD_ARGS>`
15+
Please refer to the `<BUILD_ARGS>` parameters to [Customized Build](../../dev/doc/custom-build.md#customized-build)
16+
### Optional parameters (put them before `fontcc`):
17+
1. `-e "VERSION_TAG=<tag>"`
18+
19+
`<tag>` can be the following values
20+
- `main` git main branch
21+
- `dev` git dev branch
22+
- `v28.0.5` git [release version tags](../../../tags)
23+
24+
When this variable is omitted, the tag of the latest release will be selected
25+
26+
2. `-e "NPM_REG=<npm repository mirror url>"`
27+
28+
change `npm install` download repository to mirror site.
29+
30+
eg. change npm repos to huawei mirror
31+
`docker run -it --rm -v $PWD:/work -e "NPM_REG=https://mirrors.huaweicloud.com/repository/npm" fontcc contents::Iosevka`
32+
33+
## Example
34+
### Partially Build dev branch
35+
```
36+
mkdir -p $HOME/build_fonts
37+
cd $HOME/build_fonts
38+
docker run -it --rm -v $PWD:/work -e "VERSION_TAG=dev" fontcc contents::IosevkaSS06 ttf::IosevkaSS12 webfont::IosevkaSS15
39+
ls -lR dist/
40+
```
41+
### Customized Build
42+
```
43+
cd $HOME/mycustomfonts
44+
cat myfont1.toml myfont2.toml myfont3.toml > private-build-plans.toml
45+
docker run -it --rm -v $PWD:/work fontcc ttf::myfont1 ttf::myfont2 contents::myfont3
46+
ls -lR dist/
47+
```
48+
Note: You need prepare myfont1.toml myfont2.toml myfont3.toml youself, The [Customizer](https://be5invis.github.io/Iosevka/customizer) can help you easily generate font configuration file `.toml`.

0 commit comments

Comments
 (0)