Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for roslyn client to mason.nvim #10

Open
jmederosalvarado opened this issue Nov 29, 2023 · 5 comments
Open

Add support for roslyn client to mason.nvim #10

jmederosalvarado opened this issue Nov 29, 2023 · 5 comments

Comments

@jmederosalvarado
Copy link
Owner

Arguably this is not a task to be completed on this repository but rather on mason.nvim. Creating this issue just for reference. Also relevant: #9

@nilsgehlin
Copy link

Is there something else, except for #9, that is blocking this? Or is it just a matter of making a PR in the mason-registry?

@jmederosalvarado
Copy link
Owner Author

It's just a matter of making the PR on the mason-registry right now. I have a branch of mason-registry that contains the necessary changes, just need to open the PR, but I haven't had time for this. I will try to prioritize it, but feel free to just fork and open the PR yourself.

@nilsgehlin
Copy link

I'll leave your PR to you! I wouldn't be able to answer questions about it. When it is merged in mason, it would also be nice to get it into mason-lspconfig. I think a lot of people get their LSP setups from there.

@nilsgehlin
Copy link

Are we just planning to make the language server from Microsoft installable with Mason?

It would be nice to remove the need to install this plugin separately, and just use the mason-lspconfig flow? If I understand correctly, wouldn't that require Mason to install this project, as well as the language server?

@jmederosalvarado
Copy link
Owner Author

for the language server to work with mason-lspconfig this plugin should not exist. mason-lspconfig just uses lspconfig to setup the installed server. But in the case of roslyn there are a few reasons why it can't work with nvim-lspconfig and needs a separate plugin (this plugin). See this comment for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants