Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using push options for presubmit/autosubmit votes affects every patch in a multi-commit upload #21

Open
DanAlbert opened this issue Apr 18, 2019 · 0 comments
Assignees

Comments

@DanAlbert
Copy link
Collaborator

Uploading with --autosubmit or --presubmit causes those votes to be applied to every patch in the stack for a multi-commit upload. This is how gerrit interprets the push options, so we can't trivially fix this.

We should probably stop using the push options and instead make a gerrit API call after upload to ensure that the votes are only set on the top-most patch.

@DanAlbert DanAlbert self-assigned this Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant