From eb1d2887ed98217713503025fe32cbeefd835422 Mon Sep 17 00:00:00 2001 From: Bevan Kay Date: Tue, 22 Oct 2024 14:18:26 +1100 Subject: [PATCH 1/2] triage: fix `extract_plist livecheck` label This label was never being applied because the regex only matched `strategy :extract_plist` when indented by 2 spaces, this is always at least 4 spaces because it is nested inside of a `livecheck do` block. The newline check shouldn't be necessary regardless, and removing it causes this to also match in the case that the `livecheck` is nested within another block, ie. `on_arm do`. --- .github/workflows/triage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/triage.yml b/.github/workflows/triage.yml index e5a6d02e685e..cd46ba6cddd9 100644 --- a/.github/workflows/triage.yml +++ b/.github/workflows/triage.yml @@ -72,7 +72,7 @@ jobs: - label: extract_plist livecheck path: Casks/.+ - content: \n strategy :extract_plist.*\n + content: strategy :extract_plist - label: missing zap path: Casks/.+ From 9e5951e49fcc6172f6eaa3b7d5c1a2c9eb0b7b10 Mon Sep 17 00:00:00 2001 From: Bevan Kay Date: Tue, 22 Oct 2024 20:59:47 +1100 Subject: [PATCH 2/2] triage: fix incorrect paths --- .github/workflows/triage.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/triage.yml b/.github/workflows/triage.yml index cd46ba6cddd9..5e2ffb574c7e 100644 --- a/.github/workflows/triage.yml +++ b/.github/workflows/triage.yml @@ -43,11 +43,11 @@ jobs: token: ${{secrets.HOMEBREW_GITHUB_PUBLIC_REPO_TOKEN}} def: | - label: cask deprecated - path: Cask/.+ + path: Casks/.+ content: \n deprecate!.*\n - label: cask disabled - path: Cask/.+ + path: Casks/.+ content: \n disable!.*\n - label: new cask