Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ml-kem library friction #8

Open
jmwample opened this issue Aug 30, 2024 · 1 comment
Open

ml-kem library friction #8

jmwample opened this issue Aug 30, 2024 · 1 comment

Comments

@jmwample
Copy link
Owner

PkeParams and KemParams are not public which makes it impossible to do anything useful (i.e. add implementations) for the key types ml_kem::kem::{EncapsulationKey, DecapsulationKey}

i.e. It is extremely unwieldy to do something like:

impl<P> Decapsulate<KEncodedCiphertext<P>, SharedKey<P>> for ml_kem::kem::DecapsulationKey<P>
where
    P: KemCore + EncodingSize + ParameterSet,
...
@jmwample
Copy link
Owner Author

Added a PR with a simple fix that allows KemParams to stay private while allowing (De|En)capsulationKeys to be used with generic parameters.

RustCrypto/KEMs#81

@jmwample jmwample changed the title ml-kem library annoyance ml-kem library friction Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant