Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markdown rule MD047 to resulting .md files (Files should end with a single newline character) #41

Closed
baardhermansen opened this issue Dec 4, 2023 · 2 comments · Fixed by #45
Closed

Add markdown rule MD047 to resulting .md files (Files should end with a single newline character) #41

baardhermansen opened this issue Dec 4, 2023 · 2 comments · Fixed by #45
Assignees
@joachimdalen
Labels
@area/formatter @provider/markdown @status/planned Work is planned and will be added to backlog @type/bug
Milestone
v0.1.3

Comments

@baardhermansen
Copy link

baardhermansen commented Dec 4, 2023 •
edited
Loading

What formatter are you using?

Markdown

Bicep version

v0.23.1

Bicepdocs version

0.1.2

What operating system are you using?

Windows

What is the bug you want to report?

Missing a single newline character at the end of the .md files, so they follow markdownlint rules, specifically MD047.
@baardhermansen baardhermansen added @status/needs-confirmation Bugs that needs to be verified to ensure they are an issue with the tool and not other factors @type/bug labels Dec 4, 2023
@joachimdalen
Copy link
Owner

Hi!

I'll see if I can get it done during the week, as well as some other updates. I plan to pickup development on this one again.

@joachimdalen joachimdalen added @provider/markdown @status/planned Work is planned and will be added to backlog @area/formatter and removed @status/needs-confirmation Bugs that needs to be verified to ensure they are an issue with the tool and not other factors labels Dec 5, 2023
@joachimdalen joachimdalen self-assigned this Dec 8, 2023
@joachimdalen joachimdalen added this to the v0.1.3 milestone Dec 10, 2023
@joachimdalen joachimdalen linked a pull request Dec 12, 2023 that will close this issue
Force newline at end of markdown documents #45
Merged
4 tasks
@joachimdalen
Copy link
Owner

This should be fixed in v0.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimdalen joachimdalen

Labels
@area/formatter @provider/markdown @status/planned Work is planned and will be added to backlog @type/bug
Projects
None yet
Milestone
v0.1.3
Development

Successfully merging a pull request may close this issue.

Force newline at end of markdown documents joachimdalen/bicepdocs
2 participants
@joachimdalen @baardhermansen