Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "# type: ignore" comments on v2_parser.py #28

Open
ItsNotSoftware opened this issue Aug 29, 2024 · 0 comments
Open

Remove "# type: ignore" comments on v2_parser.py #28

ItsNotSoftware opened this issue Aug 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ItsNotSoftware
Copy link
Collaborator

The use of lark + serde for parsing + serialisation was creating a lot of tough to solve mypy (type checker) errors.

The quick fix implemented was to use # type: ignore to silence these errors.
These comments should be removed and type errors fixed for better type linting.
@ItsNotSoftware ItsNotSoftware added the enhancement New feature or request label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ItsNotSoftware