Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install broken with deno 1.16.1 #41

Closed
dkolba opened this issue Nov 17, 2021 · 2 comments · Fixed by #42
Closed

Install broken with deno 1.16.1 #41

dkolba opened this issue Nov 17, 2021 · 2 comments · Fixed by #42
Assignees
@joakimunge
Labels
bug Something isn't working

Comments

@dkolba
Copy link

dkolba commented Nov 17, 2021

I am getting the error

Check https://deno.land/x/denoliver/mod.ts
error: TS2339 [ERROR]: Property 'getIterator' does not exist on type 'ReadableStream<R>'.
  return res.readable.getIterator();
                      ~~~~~~~~~~~
    at https://deno.land/[email protected]/async/pool.ts:45:23

upon install with deno 1.16.1
igk1972 pushed a commit to igk1972/denoliver that referenced this issue Dec 12, 2021
fix: set fixed version of std lib to 0.97.0 (joakimunge#41)
b708652
@joakimunge
Copy link
Owner

Hey. Thanks for reporting this. I will have a look during the week.

@joakimunge joakimunge self-assigned this Jan 31, 2022
@joakimunge joakimunge added the bug Something isn't working label Jan 31, 2022
@joakimunge joakimunge mentioned this issue Jan 31, 2022
Merged
@joakimunge
Copy link
Owner

Hi, I have merged a fix for installing this on later versions of Deno >1.16. I will push a new release shortly!

It looks like Deno has implemented native HTTP support now, so I am planning to release a major version. If you want to partake or discuss the new major version, please do so here:

#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakimunge joakimunge

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: install broken on version 1.16.1 joakimunge/denoliver
2 participants
@dkolba @joakimunge