Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Memory Leak on multiple times opening @picmo/popup-picker #279

Open
kapilkumawat86 opened this issue Jun 12, 2023 · 3 comments
Open

Memory Leak on multiple times opening @picmo/popup-picker #279

kapilkumawat86 opened this issue Jun 12, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@kapilkumawat86
Copy link

You can see if we open every time this picker, we are getting new reference but still we have old reference in memory
image

You see heap snapshot here https://goldcastio-my.sharepoint.com/:u:/g/personal/kapil_goldcast_io/Ed1c7omX8aNCppu2pxr8F60ByBk1ax_9UWIBuh3c2CbI3Q?e=tGURVU

In my opinion, at this line of code we are removing the references but the child class still have reference so can we put null also after remove.
https://github.com/joeattardi/picmo/blob/3525583e049cdea34e2ce48b9516983b9f02e209/packages/picmo/src/views/view.ts#LL209C5-L209C21

@joeattardi
Copy link
Owner

I will definitely look into this, thanks for the heap dump!

@joeattardi joeattardi added the bug Something isn't working label Jun 12, 2023
@kapilkumawat86
Copy link
Author

Hey @joeattardi , just checking any updates

@joeattardi
Copy link
Owner

I will work on this when I can. No updates yet, I have a lot going on right now.

A gentle reminder that I work on this software for free, in my spare time. I’m happy to help when I can but please manage expectations.

Also, PRs are always welcome 😎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants