Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: use the global Promise instead of bluebird #14

Closed
forivall opened this issue Sep 20, 2019 · 2 comments
Closed

feature request: use the global Promise instead of bluebird #14

forivall opened this issue Sep 20, 2019 · 2 comments

Comments

@forivall
Copy link
Contributor

It appears that the main bluebird feature you're using is timeout. In general, it's nice to not force a bluebird dependency.

@joeattardi
Copy link
Owner

I just released 1.8.0 which removes the Bluebird dependency, and instead uses the global Promise. Please feel free to file another issue if you run into problems with the new release.

@forivall
Copy link
Contributor Author

Thanks! I wasn't expecting the quick turn around since you seemed a little absent 😅 . Through using the poller in a somewhat novel setup, I found 2 new issues, and filed them at #15 and #16.

Also, I created typescript definitions, (but they're missing the new CANCEL_TOKEN, since you just added that 😄 ).

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants