Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework backend to use multiple redis connections for tree view and CLI #385

Open
sseide opened this issue Dec 27, 2019 · 0 comments
Open

Comments

@sseide
Copy link
Collaborator

sseide commented Dec 27, 2019

Current implementation uses only one connection per configured redis server. This connection is shared between the tree view operations and CLI commands for all users. Therefor its not working well with multiple commands used via CLI:

To fix these issues the connection handling must be rewritten to use multiple connections per database.

  • Main connection list may be used as is - but only for operations related to the UI tree view (fetch folder and keys for display on upper part of UI) (=> base connection). These one connect automatically on server start.
  • On first use of CLI new connection is cloned from base connection (ioredis duplicate()) and used for all CLI commands only (lazy initialize)
  • must introduce kind of user session handling to have one redis connection per user per CLI.
    Connections must be closed if user session expires/not used anymore. Very important for pub/sub and multi!

If implemented increment minor version number of RC.

@sseide sseide changed the title Rework backend to use mulptile redis connections for tree view and CLI Rework backend to use multiple redis connections for tree view and CLI Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant