Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request to add theme support to local http renderer #397

Open
bazlsi01 opened this issue Nov 5, 2024 · 1 comment
Open

Pull Request to add theme support to local http renderer #397

bazlsi01 opened this issue Nov 5, 2024 · 1 comment

Comments

@bazlsi01
Copy link

bazlsi01 commented Nov 5, 2024

So I wanted to make grip render on localhost, using the github-dark theme. It seems @parajita largely did this work on #335, however, that only applies when using the renderer in CLI mode.

I made a change to the settings.py and README.md to add THEME to settings.py and added code to app.py to look that up, and if set to pass the value to self.theme as if it had been passed on the CLI.

#396

@bazlsi01
Copy link
Author

bazlsi01 commented Nov 5, 2024

I should point out, I tested it running with THEME='dark' in ~/.grip/settings.py and without any value in settings.py and it seems to work ok. I've not added any tests, as I'm not sure how to do that (this is a trivial change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant