kubectl binary search

[Crazy-Hopper]

Hi!

Script fails to find kubectl binary in case path hashing is disabled with set +o hashall or set +h.

[johanhaleby]

Okay, what can be done about this? tis 25 juli 2023 kl. 11:28 skrev Eugene Paskevich ***@***.***

: Hi! Script fails to find kubectl binary in case path hashing is disabled with set +o hashall or set +h. — Reply to this email directly, view it on GitHub <#145>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABNVFJMVMJZXNER5PW5SEDXR6GTFANCNFSM6AAAAAA2WY4R2U> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Sent from my phone

[Crazy-Hopper]

Mmm.. I guess we have two options. Either switch from using hash function to something else like whereis or which, or add a set -o hashall in the beginning of the script.

[johanhaleby]

@Crazy-Hopper I'm not familiar with this, unfortunately. Do you know if this will have any other impact? Will it be backward-compatible?

[Crazy-Hopper]

It seems to me that set -o hashall would be the easiest way, i.e. least changes to the current code. Given that man page for this option says it's enabled by default, turning this option on won't change anything at all for most of the users. It will only fix the script for those who voluntarily disabled it for their shells.

But frankly, I'd rewrite the initial code as follows:

diff --git a/kubetail b/kubetail
index 9c7464b..d34ab38 100755
--- a/kubetail
+++ b/kubetail
@@ -1,15 +1,15 @@
 #!/bin/bash
+
 if [ -z "${KUBECTL_BIN}" ]; then
-       if hash kubectl 2>/dev/null; then
-               KUBECTL_BIN='kubectl'
-       elif hash kubectl.exe 2>/dev/null; then
-               KUBECTL_BIN='kubectl.exe'
-       elif hash microk8s 2>/dev/null; then
-               KUBECTL_BIN='microk8s.kubectl'
-       fi
+       for bin in kubectl kubectl.exe microk8s.kubectl; do
+               if type $bin &>/dev/null; then
+                       KUBECTL_BIN="$bin"
+                       break
+               fi
+       done
 fi

-if ! hash "${KUBECTL_BIN}" 2>/dev/null; then
+if ! type "${KUBECTL_BIN}" &>/dev/null; then
        echo >&2 "kubectl is not installed"
        exit 1
 fi