Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note: workspace flicker #46

Open
salkin-mada opened this issue Mar 14, 2023 · 1 comment
Open

note: workspace flicker #46

salkin-mada opened this issue Mar 14, 2023 · 1 comment

Comments

@salkin-mada
Copy link

@johnae regarding #42 #45 tested! It works. Thanks for the prompt fix.

An observation: the workspace seems to be destroyed and a new one with the same name is created just after. This results in a "flicker" of the workspace bar. Maybe its a question of refactoring? – but would it not be ideal to have a behavior similar to sway's own layout change, e.g. tabbed, stacked, split which does no such thing as a "pop/push" to the workspaces.

@johnae
Copy link
Owner

johnae commented Mar 14, 2023

@salkin-mada Absolutely, that was what I initially looked into. It's non-trivial however as sway doesn't have a way to control layout other than moving windows up, down, left, right or to a mark. You have very little control unfortunately for something like master stack or layouts in general. Persway is, in some ways, essentially a hack.

As this issue (flickering etc) affects relayout only and I personally don't change layouts on the fly that often, it seemed like a reasonable tradeoff as we can reuse the way layouts otherwise are implemented.

I'm ofc not opposed to something better and if I find the time I might give this another try (I've tried several times already though and always ended up with worse tradeoffs unfortunately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants