Won't add Annotations to pdf files.

[thepragmaticmero]

Describe the bug
Video:
Kooha-2024-09-06-13-20-13.webm

To Reproduce
Steps to reproduce the behavior:

1. Try to select a text and add an annotation

Expected behavior
To add an annotation to my .pdf file and the possibility of exporting it as .json or .

Version:

• Foliate version: 3.1.1
• OS/Distribution and version: Fedora Silverblue 41
• Desktop environment: Gnome 47
• Installation method: Fatpack (they're really fat)

Additional context
Also when supposedly "works" it doesn't highlight the text. Pls fix, it's such a letdown that doesn't work reliably :C

• Pressing Enter doesn't work
• I already added permissions to enable /home, where my book.pdf is located, on flatseal.
• Doesn't highlight text
• Works unreliably
• Crashes sometimes when I try to click on the "options" menu (button next to the trashcan)

[thepragmaticmero]

If you need journalctl I'm game.

Mmm.... the crashes are hard to replicate, maybe some vodoo magic will help.

[thepragmaticmero]

Ok the annotations are being created, it's just that the app doesn't reflect that on GTK4.

• Output after exporting as json:

    {
      "value": "epubcfi(/6/20!/4/4/50,/1:32,/1:63)",
      "color": "orange",
      "text": "are important for writing bigge",
      "note": "",
      "created": "2024-09-06T18:43:19.966Z",
      "modified": ""
    },
    {
      "value": "epubcfi(/6/20!/4/4,/62/1:7,/66/1:44)",
      "color": "yellow",
      "text": "proach and its drawbacks. Most notable is that the complete story on any particular featureis not found here, and the tutorial, by bein",
      "note": "kittycat",
      "created": "2024-09-06T18:19:18.095Z",
      "modified": "2024-09-06T18:19:22.356Z"
    },
    {
      "value": "epubcfi(/6/20!/4/4,/66/1:9,/70/1:43)",
      "color": "yellow",
      "text": "und here, and the tutorial, by being brief, may also be misleading. And because theexamples do not use the full power of C, th",
      "note": "",
      "created": "2024-09-06T18:19:30.046Z",
      "modified": ""
    },
    {
      "value": "epubcfi(/6/20!/4/4,/66/1:21,/70/1:58)",
      "color": "yellow",
      "text": "d the tutorial, by being brief, may also be misleading. And because theexamples do not use the full power of C, they are not as c",
      "note": "what the fuck man what is this",
      "created": "2024-09-06T18:42:56.985Z",
      "modified": "2024-09-06T18:43:12.895Z"
    }
  ]
}

[thepragmaticmero]

week 3.... any dev here pls?? Q-Q sad face

[johnfactotum]

Annotations aren't currently supported for PDF. There are at least two problems here. The first is that annotations don't work in all fixed-layout books, not just PDFs, because the fixed-layout renderer does not support rendering overlays (yet). The second issue is that currently all annotations are identified with EPUB CFI. Probably for PDF (and maybe even other fixed-layout books), they should be stored with the rects of the highlighted text.

[thepragmaticmero]

oh, thks 4 the knowledge, explains a lot~. I'll be around looking for the progress.~