Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/first page empty #489

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/first page empty #489

wants to merge 3 commits into from

Conversation

Fernando-hub527
Copy link
Collaborator

Description
fix bug when adding rows that have the same height as the available height on the page

Related Issue
#408

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

@Fernando-hub527 Fernando-hub527 linked an issue Oct 22, 2024 that may be closed by this pull request
first page empty with complete page filling rows #408
Open
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (da3191b) to head (2ef842b).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files          61       61           
  Lines        2331     2331           
=======================================
  Hits         2030     2030           
  Misses        268      268           
  Partials       33       33
Flag Coverage Δ
unittests 87.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnfercher johnfercher Awaiting requested review from johnfercher

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

first page empty with complete page filling rows
1 participant
@Fernando-hub527