Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Archived devices visible in my device dashboard #920

Open
4 of 7 tasks
dtech77pl opened this issue Dec 26, 2024 · 11 comments
Open
4 of 7 tasks

[Bug] Archived devices visible in my device dashboard #920

dtech77pl opened this issue Dec 26, 2024 · 11 comments
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.

Comments

@dtech77pl
Copy link

Is there an existing issue for this?

The issue occurs in the following browsers. Select at least 2.

  • Firefox
  • Chrome
  • Edge
  • Safari (unsupported) - PRs welcome
  • N/A - This is an issue with the backend

Current Behavior

Disabled Archived devices to be visible in my devices and still are there.

Expected Behavior

Cache was deleted, I have try on the new installed PC stil the same.
Remove archived devices from my-device list.

Steps To Reproduce

No response

app.conf

No response

docker-compose.yml

No response

What branch are you running?

Production

app.log

No response

Debug enabled

  • I have read and followed the steps in the wiki link above and provided the required debug logs and the log section covers the time when the issue occurs.
@dtech77pl dtech77pl added the bug 🐛 Something isn't working label Dec 26, 2024
@jokob-sk
Copy link
Owner

Hi @dtech77pl ,

Have you tried removing the archived from the UI_MY_DEVICES setting?

image

@jokob-sk jokob-sk added the Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. label Dec 27, 2024
@dtech77pl
Copy link
Author

This is how it's setup.
http://techmanski.pl/pub/ws2.jpg

jokob-sk pushed a commit that referenced this issue Dec 27, 2024
jokob-sk pushed a commit that referenced this issue Dec 27, 2024
@jokob-sk
Copy link
Owner

Thanks for the details.

I was able to reproduce the issue and the fix should be available in the next release.

If a device is DOWN and marked as ARCHIVED it will be now hidden from My Devices.

It would be great if you could test this. Can you please switch to the netalertx-dev docker image (backup everything at first or, ideally spin up a separate container with a separate db and config), in about 15 minutes (or after the last action finishes) from now?

Make sure you refresh your browser cache - and click the 🔄 refresh button in the top right corner.

Thanks in advance,
j

@jokob-sk jokob-sk added next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. and removed Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. labels Dec 27, 2024
@jokob-sk jokob-sk changed the title Archived devices visible in my device dashboard [Bug] Archived devices visible in my device dashboard Dec 27, 2024
@dtech77pl
Copy link
Author

Dev got some issue and cannot be started, got this error message:

http://techmanski.pl/pub/dev1.jpg

@jokob-sk
Copy link
Owner

Hi @dtech77pl ,

I just pushed hopefully a fix. Can you try re-downloading the dev image in ~15 min form now and follow the below steps?

Can you try restarting the application (Maintenance -> Log -> Restart Server or Restart the Container ) and clearing the cache (app AND browser cache) if that helps?

Try saving the configuration afterward.

Let me know if that helps - thanks in advance,
j

@jokob-sk jokob-sk added the Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. label Dec 30, 2024
@dtech77pl
Copy link
Author

dtech77pl commented Dec 31, 2024

I have pulled brand new instalnce of the dev and still have the same error:

DataTables warning: table id=tableDevices - Unauthorized

This is my docker settings:

version: "3"
services:
  netalertx:
    container_name: netalertx-dev-Warsaw
    hostname: netalertx-dev-Warsaw
#    ui_dark_mode: true  
#    ui_theme: dark
    privileged: true
    # use the below line if you want to test the latest dev image
    # image: "jokobsk/netalertx-dev:latest" 
    image: jokobsk/netalertx-dev:latest
    environment:
      - TZ=Europe/Warsaw
      - PORT=20222
    restart: always
    volumes:
      - /volume1/docker/netalertx-dev/config:/app/config
      - /volume1/docker/netalertx-dev/db:/app/db      
      # (optional) useful for debugging if you have issues setting up the container
      - /volume1/docker/netalertx-dev/logs:/app/front/log
#      - type: tmpfs
#        target: /app/api
    network_mode: host

@jokob-sk
Copy link
Owner

jokob-sk commented Jan 1, 2025

Hi @dtech77pl ,

Thanks for the details.

Looks like one of the NAX instances is trying to access another's GraphQL server.

Can you please make sure you have unique GRAPHQL_PORT settings across your NAX instances running on the same host?

You can initialize the setting via the ENV variable APP_CONF_OVERRIDE, like this:

services:
  netalertx_fresh:
    container_name: netalertx_fresh
    image: "jokobsk/netalertx-dev"
    network_mode: "host"
    volumes:
      - ${APP_DATA_LOCATION}/netalertx_fresh/config:/app/config
      - ${APP_DATA_LOCATION}/netalertx_fresh/db:/app/db
    environment:
      - TZ=Australia/Sydney
      - HOST_USER_ID=1036
      - HOST_USER_GID=1000
      - PORT=22222
      - ALWAYS_FRESH_INSTALL=true
      - APP_CONF_OVERRIDE={"GRAPHQL_PORT":"20223","UI_theme":"Light"}

@dtech77pl
Copy link
Author

This build fixes this. Once I have disabled archived devices from being visible in the settings, I do not see it. Thank you for this.
Can you also check the total of my device number to be counted without archived ?

@jokob-sk
Copy link
Owner

jokob-sk commented Jan 1, 2025

Hi @dtech77pl ,

Glad to hear it's working and thanks for testing it!

If you refer to the the "My Devices" count then it should update after a refresh or two. I think the value is cached.

@jokob-sk jokob-sk removed the Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. label Jan 1, 2025
@dtech77pl
Copy link
Author

You are right, number is now equal to all live devices without archived one.
Looking forward for the new stable release.

Thank you for your support

@jokob-sk
Copy link
Owner

jokob-sk commented Jan 1, 2025

Thanks for the confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.
Projects
None yet
Development

No branches or pull requests

2 participants