fix(extract): fix extract with @param in constructor doc block (#164)

Author: lyrixx

CHANGELOG.md

@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- [GH#164](https://github.com/jolicode/automapper/pull/164) Fix type extract with @param in constructor doc block
+
 ## [9.1.0] - 2024-06-06
 ### Added
 - [GH#153](https://github.com/jolicode/automapper/pull/153) Handle DateTime format in MapTo/MapFrom/Mapper attributes

src/Extractor/GetTypeTrait.php

@@ -62,7 +62,7 @@ private function extractFromDocBlock(string|false|null $rawDocNode, string $clas
 
             if (
                 $tagDocNode->value instanceof ParamTagValueNode
-                && $tagName !== '@param'
+                && $tagName === '@param'
                 && $tagDocNode->value->parameterName !== '$' . $property
             ) {
                 continue;

tests/AutoMapperTest.php

@@ -1550,4 +1550,17 @@ public function testItCanMapToClassesWithPrivatePropertiesInConstructor(): void
             )
         );
     }
+
+    public function testParamDocBlock(): void
+    {
+        $this->buildAutoMapper();
+
+        $foo = new Fixtures\IssueParamDocBlock\Foo('bar', ['foo1', 'foo2']);
+        $array = $this->autoMapper->map($foo, 'array');
+
+        self::assertSame([
+            'bar' => 'bar',
+            'foo' => ['foo1', 'foo2'],
+        ], $array);
+    }
 }

tests/Fixtures/IssueParamDocBlock/Foo.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AutoMapper\Tests\Fixtures\IssueParamDocBlock;
+
+final readonly class Foo
+{
+    /**
+     * @param string[] $foo
+     */
+    public function __construct(
+        public string $bar,
+        public array $foo,
+    ) {
+    }
+}