From dd0a6bf76d51172716c15d1ccf13b81be3febcc0 Mon Sep 17 00:00:00 2001 From: keremkabiloglu Date: Fri, 3 May 2024 14:31:53 +0300 Subject: [PATCH 1/5] limitedSwipe default value to true in GetTransitionMixin --- lib/get_navigation/src/routes/get_transition_mixin.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/get_navigation/src/routes/get_transition_mixin.dart b/lib/get_navigation/src/routes/get_transition_mixin.dart index 89cb9d72f..081e06686 100644 --- a/lib/get_navigation/src/routes/get_transition_mixin.dart +++ b/lib/get_navigation/src/routes/get_transition_mixin.dart @@ -361,7 +361,7 @@ Cannot read the previousTitle for a route that has not yet been installed''', Animation animation, Animation secondaryAnimation, Widget child, { - bool limitedSwipe = false, + bool limitedSwipe = true, double initialOffset = 0, }) { // Check if the route has an animation that's currently participating From b49023691aad8fdd98ef59f1fa30a556495fbc96 Mon Sep 17 00:00:00 2001 From: keremkabiloglu Date: Mon, 6 May 2024 11:29:20 +0300 Subject: [PATCH 2/5] fix: Update limitedSwipe default value in GetTransitionMixin --- .DS_Store | Bin 10244 -> 10244 bytes .../src/routes/get_transition_mixin.dart | 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.DS_Store b/.DS_Store index 9cc182bbc27eaf981ce927b377f223a1d5a134c7..26c0a534f0aee82f4aa317b93a0bef4c212b8ee6 100644 GIT binary patch delta 41 xcmZn(XbG6$&uG0dU^hRb_2dKriOnhktC=?Y3-92W*wC<Oa|;-NfQgMa z3P>Tz=H|P&B<18M0Yy3P%iKIJ{`IgUx{4G6Dhe`?ZEyf;-+WGJC(mYfg animation, Animation secondaryAnimation, Widget child, { - bool limitedSwipe = true, + bool limitedSwipe = false, double initialOffset = 0, }) { // Check if the route has an animation that's currently participating @@ -607,7 +607,7 @@ Cannot read the previousTitle for a route that has not yet been installed''', assert(_isPopGestureEnabled(route, canSwipe(route), context)); return _startPopGesture(route); }, - limitedSwipe: limitedSwipe, + limitedSwipe: true, gestureWidth: route.gestureWidth?.call(context) ?? _kBackGestureWidth, initialOffset: initialOffset, From 4ef01056e3ef5f597ff25ab2b86ea4751df19e19 Mon Sep 17 00:00:00 2001 From: keremkabiloglu Date: Mon, 6 May 2024 11:43:35 +0300 Subject: [PATCH 3/5] refactor: Update limitedSwipe default value in GetTransitionMixin --- lib/get_navigation/src/routes/get_transition_mixin.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/get_navigation/src/routes/get_transition_mixin.dart b/lib/get_navigation/src/routes/get_transition_mixin.dart index 29c9d70e5..89cb9d72f 100644 --- a/lib/get_navigation/src/routes/get_transition_mixin.dart +++ b/lib/get_navigation/src/routes/get_transition_mixin.dart @@ -607,7 +607,7 @@ Cannot read the previousTitle for a route that has not yet been installed''', assert(_isPopGestureEnabled(route, canSwipe(route), context)); return _startPopGesture(route); }, - limitedSwipe: true, + limitedSwipe: limitedSwipe, gestureWidth: route.gestureWidth?.call(context) ?? _kBackGestureWidth, initialOffset: initialOffset, From b3cef01afac9b5efc57133d64c3feef122b40683 Mon Sep 17 00:00:00 2001 From: keremkabiloglu Date: Mon, 6 May 2024 12:16:15 +0300 Subject: [PATCH 4/5] refactor: Update limitedSwipe default value in cupertino transition --- lib/get_navigation/src/routes/get_transition_mixin.dart | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/get_navigation/src/routes/get_transition_mixin.dart b/lib/get_navigation/src/routes/get_transition_mixin.dart index 89cb9d72f..40c659713 100644 --- a/lib/get_navigation/src/routes/get_transition_mixin.dart +++ b/lib/get_navigation/src/routes/get_transition_mixin.dart @@ -116,7 +116,6 @@ class GetBackGestureDetectorState extends State> { ) }, ); - return Stack( fit: StackFit.passthrough, children: [ @@ -607,7 +606,7 @@ Cannot read the previousTitle for a route that has not yet been installed''', assert(_isPopGestureEnabled(route, canSwipe(route), context)); return _startPopGesture(route); }, - limitedSwipe: limitedSwipe, + limitedSwipe: true, gestureWidth: route.gestureWidth?.call(context) ?? _kBackGestureWidth, initialOffset: initialOffset, From d809ae0281bd6a6008362f94ebf67a9c40f18c97 Mon Sep 17 00:00:00 2001 From: keremkabiloglu Date: Mon, 20 May 2024 17:11:00 +0300 Subject: [PATCH 5/5] limitedSwipe = true to fix issue #2705 --- .DS_Store | Bin 10244 -> 10244 bytes lib/.DS_Store | Bin 0 -> 8196 bytes .../src/routes/default_transitions.dart | 13 +++++++------ .../src/routes/get_transition_mixin.dart | 4 ++-- 4 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 lib/.DS_Store diff --git a/.DS_Store b/.DS_Store index 26c0a534f0aee82f4aa317b93a0bef4c212b8ee6..0d88dba877b0171fba97004ea21f8e542af10ef9 100644 GIT binary patch delta 694 zcmZn(XbIS0B*3I~YjT2s)MP&aF81B&UoRd1dvtQVfGQGOQl}upFgQ6sw}1f*z!VFE z9z!}qCPPV1Izo;~bx-Hy3jz}CiBDZmgA95vAPHyl3raB=JeaI4sKj`3vY()w?x`>N zk4rxtbp#s94l|7*gQ1imDK|gGB`GIA2`Iw>RW*60V6v`_NCC2rGKOM?WQKf(6oyn} z9Z*%9HH91)nfX#JCSMSio7^SL!*21i5Tt$bd13j;s+v4gM4p*}>A>XOBAP4=>|CXj_lU@dPN)C9-bU8po+wn)G5d?3{K9^EnonH01(N- zpvRETkjYSzla7#Ma;+1cd_h2hy?BFj-qriSfi_KS4R& z1e(SUGmRmGp_CyhH$TNCDJMS(D8m6&HF>6BvTnZRViU;Y$oRVqUTLn1>iLjgk$s#Q=`lV^&^GwbXMn7ms=lf_r`e8%KG zA~GVm`7Ur@{5%0M4l0509@fB@F$pGKfz2<(?3m*iZ%zfrQwc*VFq}$|wFY~|hHD-Mdya(xE{|{&HhE;X bF)%&Y+#=P(#ewX4pnnl2AWKluTQZCQO(x+& diff --git a/lib/.DS_Store b/lib/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..6de465102b6c4df34ad46866ed528315a226207e GIT binary patch literal 8196 zcmeI1zl#$=6vy8rr$i&7m50?9B39!40YW??XeD@vg~e(1LJVfJN6emLwXLoHg8zVp zBG?NS7J^vVsn=TB%7NeaW^Q&SyPM>=!b4|{-4}MgFY}piW`DdrB2w$w)*8_&5w);! zJk!RmqH#ZOrPeSa~&lW->ItyWm1(XF_cb6 zf5dXcj)}RBI-QhGCuK%frb1CNI`Sfslj`Ug_Q8SRK-mGV-A~hi`l#49z50DfDXRI$ zqruunoF>~k_2%bA`Xudkd!w`mUF-a}Y&ZM${@UW4tpn$5KXkbS@1&ha4E6+nn1RnP zmxoH7%l&)Ta@S}J-bGrUQ?5>Jk8=!{`xMjEBUR_#!nGQu%lhR?h`hs^Ez0aKk#W~-`Al|_nvw^%ZlQYiqw)y?SBE8Fh)<>ZvCIoQ;%C^_rUG-yPO|>TFx0w!Bwa6I2sX#p|h4luYoDfr%iba$#dsx z+r*=zAJ3P|a+!Ml7gL- animation, - Animation secondaryAnimation, - Widget child) { + BuildContext context, + Curve? curve, + Alignment? alignment, + Animation animation, + Animation secondaryAnimation, + Widget child, + ) { return SlideTransition( position: Tween( begin: const Offset(-1.0, 0.0), diff --git a/lib/get_navigation/src/routes/get_transition_mixin.dart b/lib/get_navigation/src/routes/get_transition_mixin.dart index bd3e1574a..03e8c5a9b 100644 --- a/lib/get_navigation/src/routes/get_transition_mixin.dart +++ b/lib/get_navigation/src/routes/get_transition_mixin.dart @@ -360,7 +360,7 @@ Cannot read the previousTitle for a route that has not yet been installed''', Animation animation, Animation secondaryAnimation, Widget child, { - bool limitedSwipe = false, + bool limitedSwipe = true, double initialOffset = 0, }) { // Check if the route has an animation that's currently participating @@ -605,7 +605,7 @@ Cannot read the previousTitle for a route that has not yet been installed''', assert(_isPopGestureEnabled(route, canSwipe(route), context)); return _startPopGesture(route); }, - limitedSwipe: true, + limitedSwipe: limitedSwipe, gestureWidth: route.gestureWidth?.call(context) ?? _kBackGestureWidth, initialOffset: initialOffset,