Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all the Subprocess.Popen instances #7

Open
jonjohansen opened this issue May 10, 2019 · 0 comments
Open

Refactor all the Subprocess.Popen instances #7

jonjohansen opened this issue May 10, 2019 · 0 comments

Comments

@jonjohansen
Copy link
Owner

These are really messy, and none of the output is validated.
A thorough cleanse to check that the intended output is given from running the cmd should be done.
Also constantly calling process.wait() isn't ideal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonjohansen