Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapid is S7_object? #89

Closed
jimrothstein opened this issue Apr 22, 2024 · 2 comments
Closed

rapid is S7_object? #89

jimrothstein opened this issue Apr 22, 2024 · 2 comments

Comments

@jimrothstein
Copy link
Contributor

jimrothstein commented Apr 22, 2024

As a(n) WHO, I WHAT, so that WHY.

Little confusing (to me, as new to Rapid and new to S7)

Why is class for rapid named class_rapid ?

From S7 vignettes, I thought new class is created like so:

There is no class_dog.

# dog is a function, contructor
dog =  S7::new_class("dog", properties = ....<snip>)

# create instance of class dog
lola = dog("lola", properties ...<snip>)

SEE:
https://rconsortium.github.io/S7/articles/S7.html

@jonthegeek
Copy link
Owner

Arguments like info = info() caused issues. Differentiating the constructor from what it represent avoided bugs and made everything less confusing. I'll try to write up a blog illustrating why I did this at some point.

@jonthegeek jonthegeek closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
@jimrothstein
Copy link
Contributor Author

jimrothstein commented Apr 23, 2024

Got it ... just needed to work S7 & its terminology.

I supposed you might feel the point is not to need to delve into S7. For those unable to refrain, perhaps a fewer points/comments might be welcome.

Will collect various S7 objects you use.
Reviewing your tests/testthat/test-zz-rapid.R (checking s3, s7, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants