Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_lgl() #21

Closed
7 tasks done
jonthegeek opened this issue Aug 9, 2023 · 4 comments · Fixed by #34
Closed
7 tasks done

to_lgl() #21

jonthegeek opened this issue Aug 9, 2023 · 4 comments · Fixed by #34
Milestone
v0.1

Comments

@jonthegeek
Copy link
Owner

jonthegeek commented Aug 9, 2023 •
edited
Loading

Add to_lgl().

  • lgl
  • NULL
  • int: only 0 and 1? option about this?
  • character: as.logical does an ok job, but silently makes NAs. It fails for weird mixed capitalization ("trUE" etc). Is that ok? Do we want to accept something like "1"?
  • double: probably convert to int first and follow those rules, if any coercion is allowed.
  • Consider other cases, but I suspect they should all be neglected.
  • Any other special args?
@jonthegeek
Copy link
Owner Author

Also make a dummy internal version of this that can be used by other functions within this package (including by this function). Can it work for it to call itself?

@jonthegeek jonthegeek added this to the v0.1 milestone Aug 10, 2023
@jonthegeek jonthegeek changed the title lgl to_lgl() Aug 10, 2023
@jonthegeek
Copy link
Owner Author

Additional to_lgl.int() options split off into #29.

@jonthegeek
Copy link
Owner Author

to_lgl.character() optoins split into #30.

@jonthegeek
Copy link
Owner Author

to_lgl.double() options in #31.

@jonthegeek jonthegeek mentioned this issue Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
{stbl} releases
Archived in project
Milestone
v0.1
Development

Successfully merging a pull request may close this issue.

Implement to_lgl(). jonthegeek/stbl
1 participant
@jonthegeek