Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interested in PRs? #2

Open
kylebarron opened this issue Sep 24, 2023 · 3 comments
Open

Interested in PRs? #2

kylebarron opened this issue Sep 24, 2023 · 3 comments

Comments

@kylebarron
Copy link

  1. I think it's important to have efficient and easy to use interop between geoarrow and shapely, and I think this is the best point to start from. Are you interested in any PRs to this package? I.e. are you still interested in maintaining it?

  2. I was talking with @paleolimbot a little while ago and we discussed a namespacing approach to geoarrow in Python. So I could distribute my rust bindings with geoarrow.rust and Dewey could distribute his with e.g. geoarrow.c and they'd be able to interoperate with each other. The main important note here is that there can't be a geoarrow Python package with an __init__.py in geoarrow/__init__.py because then the namespaced modules will never be found (ref native namespacing docs). So if you do plan to publish this to PyPI, would you be interested in changing the name to be something like geoarrow.python or geoarrow.shapely (or something else)?

    In consultation with you and Dewey it might also be a good idea to take the geoarrow top level python package name so no one ends up publishing a geoarrow package that just installs the other namespace packages.

@kylebarron
Copy link
Author

kylebarron commented Sep 24, 2023

Also I've been thinking about moving https://github.com/kylebarron/geoarrow-rs to the geoarrow org; would you be interested in moving this or a similar pure-python geoarrow implementation to the geoarrow org? It might be nice to have all the implementations under the same org

Edit: I'd forgotten I'd even created a geoarrow-python repo in the geoarrow org 😂 https://github.com/geoarrow/geoarrow-python

@paleolimbot
Copy link

Yeah and I can move geoarrow-pandas and geoarrow-pyarrow to geoarrow/geoarrow-python so all the non-native interfaces are all in one place!

@kylebarron
Copy link
Author

I made geoarrow/geoarrow-python#2 and we can probably discuss there 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants