Suggest alternatives to instance initializers

[chriskrycho]

While instance initializers are powerful and capable of doing what you describe using them for here, they are also (in my experience) pretty serious foot-guns and can make it very difficult for someone to find where something is actually configured—especially in a sufficiently large app.

An alternative recommendation and approach might be to set up the client explicitly during app boot (e.g. in the application controller or route), and to provide a test helper which does the same, so that for component tests where you care about it, you explicitly opt in:

import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
import { setupApolloTest } from 'glimmer-apollo';

module('Integration | Component | GraphCoolYo', function(hooks) {
  setupRenderingTest(hooks);
  setupApolloTest(hooks);

  test('renders', async function (assert) {
    await render(hbs`<GraphCoolYo @id={{123}} />`);
    // etc.
  });
});

This also makes it much clearer when reading the test that it does need this kind of thing, and isn’t just implicitly/magically working. We do this for a variety of kinds of test hooks on the app I work on and it's slightly more verbose, but way easier for people to understand.