Implement blocklist for upstream repos (#669)

Author: christian-schilling

josh-proxy/src/bin/josh-proxy.rs

@@ -467,6 +467,22 @@ async fn call_service(
         return Ok(builder.body(hyper::Body::empty())?);
     }
 
+    let block = std::env::var("JOSH_REPO_BLOCK").unwrap_or("".to_owned());
+    let block = block.split(";").collect::<Vec<_>>();
+
+    for b in block {
+        if b == parsed_url.upstream_repo {
+            return Ok(make_response(
+                hyper::Body::from(formatdoc!(
+                    r#"
+                    Access to this repo is blocked via JOSH_REPO_BLOCK
+                    "#
+                )),
+                hyper::StatusCode::UNPROCESSABLE_ENTITY,
+            ));
+        }
+    }
+
     match fetch_upstream(
         serv.clone(),
         parsed_url.upstream_repo.to_owned(),

tests/proxy/clone_blocked.t

@@ -0,0 +1,15 @@
+  $ . ${TESTDIR}/setup_test_env.sh
+  $ cd ${TESTTMP}
+
+  $ git clone -q http://localhost:8002/blocked_repo.git
+  remote: Access to this repo is blocked via JOSH_REPO_BLOCK
+  fatal: unable to access 'http://localhost:8002/blocked_repo.git/': The requested URL returned error: 422
+  [128]
+
+  $ bash ${TESTDIR}/destroy_test_env.sh
+  refs
+  |-- heads
+  `-- tags
+  
+  2 directories, 0 files
+

tests/proxy/setup_test_env.sh

@@ -5,12 +5,15 @@ killall hyper-cgi-test-server >/dev/null 2>&1 || true
 
 git init --bare ${TESTTMP}/remote/real_repo.git/ 1> /dev/null
 git config -f ${TESTTMP}/remote/real_repo.git/config http.receivepack true
+git init --bare ${TESTTMP}/remote/blocked_repo.git/ 1> /dev/null
+git config -f ${TESTTMP}/remote/blocked_repo.git/config http.receivepack true
 git init --bare ${TESTTMP}/remote/real/repo2.git/ 1> /dev/null
 git config -f ${TESTTMP}/remote/real/repo2.git/config http.receivepack true
 export RUST_LOG=trace
 
 export GIT_CONFIG_NOSYSTEM=1
 export JOSH_SERVICE_NAME="josh-proxy-test"
+export JOSH_REPO_BLOCK="/blocked_repo.git"
 
 GIT_DIR=${TESTTMP}/remote/ GIT_PROJECT_ROOT=${TESTTMP}/remote/ GIT_HTTP_EXPORT_ALL=1 hyper-cgi-test-server\
     --port=8001\