-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low Contrast #140
Comments
@MatsSvensson i think you need to write that Github itself. |
I meant the documentation on http://gethead.info/ Dragging GitHub out from the low-contrast era, is a project that's beyond me. |
@MatsSvensson are you talking about the code comments? If so they are currently According to WebAIM the current |
I just try to make some different style of syntax highlight which is on dark mode #152 |
Maybe using a different theme would work, since its GitHub Pages, the theme can be changed to something that has better highlighting. I'm not certain if a theme can be edited though....i would be good if it was possible. |
I'm a little late to this party but having only recently been introduced to your great reference project, my initial reaction to the website is I am in complete agreement that the code blocks are unnecessarily difficult to read. This is to the point that personally I'll not visit the website, and instead just view the rendering within the github repo directly. Using such a dark background and only slightly lighter text - i.e. poor contrast - seems to be an issue. I would suggest either making the background less dark, else making the text more vibrant. Ultimately, this is a theme issue. |
A brief experiment with the colours / adjusting sliders suggests swapping the following could be some quick wins, though I imagine it may be better to find a full theme and/or do it systematically:
I'm not entirely sure how github pages works and whether it automatically re-compiles the site (scss) on edit, but I presume that editing the colours within the scss files would then adjust the display of the site. Before: |
I just found out that the browser extension "Dark Reader" fixes this. Also fixes some other problems that my colorblind self had :) You can find it here |
Great list!
But a lot of the text has too low contrast to be comfortably read on many screens.
(and/or if you are over 40)
"Graying out" text is not a good way to make it distinct from other text.
It should only be used on text you don't want people to read.
The text was updated successfully, but these errors were encountered: