Tweaks following review by KaptenJansson

samdutton · samdutton · commit df307244ad2e · 2016-02-01T09:33:03.000Z
diff --git a/src/content/peerconnection/webaudio-output/css/main.css b/src/content/peerconnection/webaudio-output/css/main.css
@@ -1,5 +1,5 @@
 /*
-*  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+*  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 *
 *  Use of this source code is governed by a BSD-style license
 *  that can be found in the LICENSE file in the root of the source
diff --git a/src/content/peerconnection/webaudio-output/index.html b/src/content/peerconnection/webaudio-output/index.html
@@ -1,6 +1,6 @@
 <!DOCTYPE html>
 <!--
- *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+ *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
diff --git a/src/content/peerconnection/webaudio-output/js/main.js b/src/content/peerconnection/webaudio-output/js/main.js
@@ -1,5 +1,5 @@
 /*
- *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+ *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
@@ -35,7 +35,7 @@ remoteVideo.addEventListener('loadedmetadata', function() {
     'px,  videoHeight: ' + this.videoHeight + 'px');
 });
 
-remoteVideo.onresize = function() {
+remoteVideo.addEventListener('resize', function() {
   trace('Remote video size changed to ' +
     remoteVideo.videoWidth + 'x' + remoteVideo.videoHeight);
   // We'll use the first onsize callback as an indication that video has started
@@ -45,7 +45,7 @@ remoteVideo.onresize = function() {
     trace('Setup time: ' + elapsedTime.toFixed(3) + 'ms');
     startTime = null;
   }
-};
+});
 
 var localStream;
 var pc1;
diff --git a/src/content/peerconnection/webaudio-output/js/test.js b/src/content/peerconnection/webaudio-output/js/test.js
diff --git a/src/content/peerconnection/webaudio-output/js/third_party/streamvisualizer.js b/src/content/peerconnection/webaudio-output/js/third_party/streamvisualizer.js
@@ -29,6 +29,7 @@ function StreamVisualizer(remoteStream, canvas) {
   console.log('Creating StreamVisualizer with remoteStream and canvas: ',
     remoteStream, canvas);
   this.canvas = canvas;
+  this.drawContext = this.canvas.getContext('2d');
 
   // cope with browser differences
   if (typeof AudioContext === 'function') {
@@ -68,9 +69,7 @@ StreamVisualizer.prototype.draw = function() {
   this.analyser.getByteFrequencyData(this.freqs);
   this.analyser.getByteTimeDomainData(this.times);
 
-  // var width = Math.floor(1/this.freqs.length, 10);
 
-  var drawContext = this.canvas.getContext('2d');
   this.canvas.width = WIDTH;
   this.canvas.height = HEIGHT;
   // Draw the frequency domain chart.
@@ -81,8 +80,8 @@ StreamVisualizer.prototype.draw = function() {
     var offset = HEIGHT - height - 1;
     var barWidth = WIDTH/this.analyser.frequencyBinCount;
     var hue = i/this.analyser.frequencyBinCount * 360;
-    drawContext.fillStyle = 'hsl(' + hue + ', 100%, 50%)';
-    drawContext.fillRect(i * barWidth, offset, barWidth, height);
+    this.drawContext.fillStyle = 'hsl(' + hue + ', 100%, 50%)';
+    this.drawContext.fillRect(i * barWidth, offset, barWidth, height);
   }
 
   // Draw the time domain chart.
@@ -92,8 +91,8 @@ StreamVisualizer.prototype.draw = function() {
     height = HEIGHT * percent;
     offset = HEIGHT - height - 1;
     barWidth = WIDTH/this.analyser.frequencyBinCount;
-    drawContext.fillStyle = 'white';
-    drawContext.fillRect(i * barWidth, offset, 1, 2);
+    this.drawContext.fillStyle = 'white';
+    this.drawContext.fillRect(i * barWidth, offset, 1, 2);
   }
 
   requestAnimationFrame(this.draw.bind(this));

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`-* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.`
	`2`	`+* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.`
`3`	`3`	`*`
`4`	`4`	`* Use of this source code is governed by a BSD-style license`
`5`	`5`	`* that can be found in the LICENSE file in the root of the source`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`<!DOCTYPE html>`
`2`	`2`	`<!--`
`3`		`- * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.`
	`3`	`+ * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.`
`4`	`4`	`*`
`5`	`5`	`* Use of this source code is governed by a BSD-style license`
`6`	`6`	`* that can be found in the LICENSE file in the root of the source`