Skip to content

fix: add yq prior to 4.18.* support #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: add yq prior to 4.18.* support #46

wants to merge 1 commit into from

Conversation

@realFrogboy
Copy link

@realFrogboy realFrogboy commented Nov 1, 2024 •
edited
Loading

Hi, thank you for your wonderful plugin!

I've tried to install it on my machine and received the following error message:

Error: unknown command ".icons.\"vim\"" for "yq"
Run 'yq --help' for usage.
bash: [: bin/defaults.yml: integer expression expected
Error: unknown command ".config.show-name" for "yq"
Run 'yq --help' for usage.

The source of the issue was that yq on my system has 4.2.0 version and according to this discussion mikefarah/yq#1158 (comment) prior to 4.18.x eval word must be specified before the actual commands.

I've added a check of the yq version and inserted eval if it's actually required.

@joshmedeski
Copy link
Owner

joshmedeski commented Nov 4, 2024

Thanks for looking into this and writing up backwards compatability.

yq version 4.17 is almost 3 years old right now. So, rather than adding additional complexity to the project, are you able to upgrade yq on your machine? To my knowledge it's not something included on many operating systems so it seems reasonable to require the dependency be ya v4.18 or highter.

Let me know your thoughts, thanks.

@joshmedeski
Copy link
Owner

joshmedeski commented Nov 13, 2024

@realFrogboy you've got merge conflicts

@joshmedeski
Copy link
Owner

joshmedeski commented Nov 3, 2025

I'd rather not support a 3+ year old dependency for this project, feel free to fork it if you need to support an older version, hope you understand.

@joshmedeski joshmedeski closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@realFrogboy @joshmedeski