Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Check node version for CRA in Initialization component #322

Open
1 task
AWolf81 opened this issue Nov 2, 2018 · 2 comments
Open
1 task

Check node version for CRA in Initialization component #322

AWolf81 opened this issue Nov 2, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@AWolf81
Copy link
Collaborator

AWolf81 commented Nov 2, 2018

Describe the bug
Project creation fails with-out an error message because of an old node version (see screenshot below).
I have to update my VM ware node version.

To Reproduce

  1. Check your node version and use a version <8.10.0 (e.g. 8.9.3) (use nvm)
  2. Enable LOGGING in src/config/app.js
  3. Create a new CRA project
  4. Check the console output

Expected behavior

  • On app load check that the Node version is matching the required version. If not, display a message and don't render guppy.
  • Or we could add a check to Project creation for CRA to catch the error, display a message & abort installation.
  • Version to check see screenshot. Check with semver & check three versions 6 || 8 || 10.

TODOs

  • Check requirements of Gatsby & Next.js. We have to meet these version too.

Screenshots
grafik

Environment (please complete the following information):

  • OS: Ubutnu 16.04.3 (but will also occur cross-platform)
  • Version: master
  • Node version: 8.9.3
@AWolf81 AWolf81 added the bug Something isn't working label Nov 2, 2018
@joshuaellis
Copy link
Contributor

Hi @AWolf81

Happy to look into this. Thinking it might be a good place to use the info bar created in #352 to display the error. What do you think?

On app load check that the Node version is matching the required version. If not, display a message and don't render guppy.

I can't seem to see a clear node version that's required to run Guppy, if it can be run on any version then showing the app isn't wrong? What do you think?

@AWolf81
Copy link
Collaborator Author

AWolf81 commented Mar 21, 2019

@joshuaellis Please have a look into it.

Yes, I think the info bar works here too.

We can render everything and just show the info and disable project creation if the Node version is not correct.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants