Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use replace strategy in replication configurations. #190

Closed
pritchardtw opened this issue Aug 8, 2024 · 2 comments
Closed

Use replace strategy in replication configurations. #190

pritchardtw opened this issue Aug 8, 2024 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@pritchardtw
Copy link

pritchardtw commented Aug 8, 2024

Is your feature request related to a problem? Please describe.
When updating replication configuration it will not replace existing rules, but append to them. So when swapping starttls from "critical" to "no", it adds 3 additions syncrepls, instead of replacing the 3 that were created at bootstrap time.

kubectl exec -it ldap-2 -- /bin/bash -c "ldapmodify -H ldap://localhost:1389 -D <admin> -w <password> -f custom-config/03_brep-modify.ldif"

Describe the solution you'd like
We can swap
https://github.com/jp-gouin/helm-openldap/blob/master/templates/configmap-replication-acls.yaml#L43
https://github.com/jp-gouin/helm-openldap/blob/master/templates/configmap-replication-acls.yaml#L46
https://github.com/jp-gouin/helm-openldap/blob/master/templates/configmap-replication-acls.yaml#L57
https://github.com/jp-gouin/helm-openldap/blob/master/templates/configmap-replication-acls.yaml#L62

From add -> replace which is essentially an upsert.

This also makes the ldapmodify idempotent.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
I've manully edited my chart to do this.

Additional context
Add any other context or screenshots about the feature request here.

@pritchardtw pritchardtw added the enhancement New feature or request label Aug 8, 2024
@jp-gouin
Copy link
Owner

jp-gouin commented Aug 9, 2024

Hi @pritchardtw , would you like to submit a PR ?

Copy link

stale bot commented Oct 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 9, 2024
@stale stale bot closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants