Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect translation link in multihost mode #988

Closed
shane-yao opened this issue Jan 3, 2025 · 1 comment · Fixed by #990
Closed

Incorrect translation link in multihost mode #988

shane-yao opened this issue Jan 3, 2025 · 1 comment · Fixed by #990

Comments

@shane-yao
Copy link
Contributor

I found that maybe a bug(?) if the hugo site is configured in multihost mode(different languages use different base urls).

I checked translations.html's code and found that different language's url is using RelPermalink as href target.This might have some problems if the site is in multihost mode.

So, I think would be more suitable using Permalink in multihost mode. Please correct me if this is wrong. I will make a PR later.
shane-yao added a commit to shane-yao/congo that referenced this issue Jan 3, 2025
@shane-yao
🐛 Fix: incorrect translation link in multihost mode jpanther#988
9ad2fa7
@jpanther jpanther linked a pull request Feb 23, 2025 that will close this issue
🐛 Fix: incorrect translation link in multihost mode #988 #990
Merged
jpanther added a commit that referenced this issue Feb 23, 2025
@jpanther
🔀 Merge pull request #990 from shane-yao/dev
b6bc820 
🐛 Fix: incorrect translation link in multihost mode #988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix: incorrect translation link in multihost mode #988 shane-yao/congo
2 participants
@shane-yao and others