Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all PCRE2 constants into enums in modPcre #8

Open
jpbro opened this issue May 30, 2017 · 2 comments
Open

Move all PCRE2 constants into enums in modPcre #8

jpbro opened this issue May 30, 2017 · 2 comments
Assignees
@jpbro
Labels
enhancement

Comments

@jpbro
Copy link
Owner

jpbro commented May 30, 2017

Currently some PCRE2 constants are scattered around the various classes. I think they should all be moved into enums in modPcre2 to keep them all in one place and allow them to be re-used in various classes while remaining hidden from the host.
@jpbro jpbro self-assigned this May 30, 2017
@dragokas
Copy link

No objections.
If you want, you can just append each group of enums with comment, in which class this enum is currently used.

@jpbro
Copy link
Owner Author

jpbro commented Jun 1, 2017

Good idea re: the comments @dragokas, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpbro jpbro

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpbro @dragokas