IPv6 remotes support (closes #197, thanks @shawnhwei)

* Support IPv6 remotes

* Adjust validation for IPv6 remotes

* IPv6 refactoring

* Further loosen remote part matching regex

Author: Shawn Hwei

share/settings/remote.go

@@ -46,7 +46,7 @@ func DecodeRemote(s string) (*Remote, error) {
 		s = strings.TrimPrefix(s, revPrefix)
 		reverse = true
 	}
-	parts := strings.Split(s, ":")
+	parts := regexp.MustCompile(`(\[[^\[\]]+\]|[^\[\]:]+):?`).FindAllStringSubmatch(s, -1)
 	if len(parts) <= 0 || len(parts) >= 5 {
 		return nil, errors.New("Invalid remote")
 	}
@@ -55,7 +55,7 @@ func DecodeRemote(s string) (*Remote, error) {
 	//then to set 'local' fields second (allows the 'remote' side
 	//to provide the defaults)
 	for i := len(parts) - 1; i >= 0; i-- {
-		p := parts[i]
+		p := parts[i][1]
 		//remote portion is socks?
 		if i == len(parts)-1 && p == "socks" {
 			r.Socks = true
@@ -144,7 +144,7 @@ func isPort(s string) bool {
 }
 
 func isHost(s string) bool {
-	_, err := url.Parse(s)
+	_, err := url.Parse("//" + s)
 	if err != nil {
 		return false
 	}

share/settings/remote_test.go

@@ -40,6 +40,15 @@ func TestRemoteDecode(t *testing.T) {
 			},
 			"R:0.0.0.0:80:google.com:80",
 		},
+		{
+			"示例網站.com:80",
+			Remote{
+				LocalPort:  "80",
+				RemoteHost: "示例網站.com",
+				RemotePort: "80",
+			},
+			"0.0.0.0:80:示例網站.com:80",
+		},
 		{
 			"socks",
 			Remote{
@@ -81,6 +90,27 @@ func TestRemoteDecode(t *testing.T) {
 			},
 			"localhost:5353:1.1.1.1:53/udp",
 		},
+		{
+			"[::1]:8080:google.com:80",
+			Remote{
+				LocalHost:  "[::1]",
+				LocalPort:  "8080",
+				RemoteHost: "google.com",
+				RemotePort: "80",
+			},
+			"[::1]:8080:google.com:80",
+		},
+		{
+			"R:[::]:3000:[::1]:3000",
+			Remote{
+				LocalHost:  "[::]",
+				LocalPort:  "3000",
+				RemoteHost: "[::1]",
+				RemotePort: "3000",
+				Reverse:    true,
+			},
+			"R:[::]:3000:[::1]:3000",
+		},
 	} {
 		//expected defaults
 		expected := test.Output