Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepped Tracker #2886

Open
4 of 5 tasks
joshwooding opened this issue Jan 5, 2024 · 28 comments
Open
4 of 5 tasks

Stepped Tracker #2886

joshwooding opened this issue Jan 5, 2024 · 28 comments
Assignees
Labels
adopter: pepper community: core-release-candidate Community feedback wanted on Lab component before it is move to production ready / core package component: stepped tracker priority: high 😡 type: component 📦

Comments

@joshwooding
Copy link
Contributor

joshwooding commented Jan 5, 2024

Tasks

  1. 10 of 12
    adopter: pepper component: stepped tracker
    ivan-calderon tomhazledine
  2. 0 of 11
    adopter: pepper component: stepped tracker
    ivan-calderon tomhazledine
  3. 0 of 11
    component: stepped tracker
  4. 0 of 11
    component: stepped tracker role: design 🎨 role: dev 💻 type: enhancement 💡

Enhancements

  1. adopter: pepper component: stepped tracker priority: high 😡 role: design 🎨
@mark-tate
Copy link
Contributor

Pepper requirements include 'warning', 'error' (TBD 'deadend'), small breakpoint as per Pepper pattern, Salt to allow no label on step

@mark-tate
Copy link
Contributor

Zazu Goal: M(5)

  • merge to RC, a known state
  • stakeholder review required
  • draft docs/design ready to publish

Outstanding Questions:
Icon size, are they too small ?

@tomhazledine
Copy link
Contributor

  • New approach to icon sizing (1.5x for all steps, 1x for sub-steps) signed-off.
  • Still to finish in code: icon sizing implementation and accordion-mechanic for nested steps

@tomhazledine
Copy link
Contributor

@tomhazledine
Copy link
Contributor

accordion mechanic taking longer than expected. New ETA for "ready to review": Wednesday

@tomhazledine
Copy link
Contributor

Icon size changes ready for design review.
Accordion still in-progress, expect to be ready for design review by EOW.

@tomhazledine
Copy link
Contributor

Size and spacing adjustments required following design review.
Had catchup with James Sol to ensure we're all in sync with requirements.
Expecting to be ready for dev review by Friday

@tomhazledine
Copy link
Contributor

Slider work has pushed this back a little. Expecting dev work complete by the middle of next week

@mark-tate
Copy link
Contributor

Goal: finish accordion mechanic for nested steps
Design and dev signoff by EOS

@tomhazledine
Copy link
Contributor

Dev work on functionality complete.
Adding tests and example stories while waiting for design review.

@tomhazledine
Copy link
Contributor

Fine-tuning based on design feedback (mostly typography and spacing tweaks)

@mark-tate
Copy link
Contributor

Cortado Goal :
Merge to Labs and docs published
Third Party feedback before merge to Core

@tomhazledine
Copy link
Contributor

Final dev tweaks to pass design review (plus discussion about right-hand spacing for sub-steps)
Expect to be ready for dev review by EOD Friday

@origami-z
Copy link
Contributor

Aug 12 - Adding test, closing to get team review

@ivan-calderon
Copy link
Contributor

@tomhazledine thank you for the updates. I just re-ran design review. There are still some details to be addressed. Please see unresolved challenges to the bottom of the Design review in Figma. Please feel free to schedule a call if required considering that we are mid-sprint and you still required code reviews in the coming days. TY!

@tomhazledine
Copy link
Contributor

Aug 14 - Design sign-off
Aug 16 - Site example and QA stories added. Ready for dev review

@origami-z
Copy link
Contributor

Possible a11y review - label / announcement around nested (expand / collapse)

@mark-tate
Copy link
Contributor

Jacob to do accessibility review during Espresso

@jake-costa
Copy link

Sent Tom the a11y review for stepped tracker 9/11/24. Can setup a call to review the report if needed.

@mark-tate
Copy link
Contributor

Frappe Goal:
James Sol to review and PR raised to Labs
Invite more feedback and a plan to move to Core

@tomhazledine
Copy link
Contributor

Have reviewed a11y feedback at will start implementing tomorrow (18th)

@mark-tate
Copy link
Contributor

Should have a11y updates complete by next standup

@mark-tate mark-tate added the community: core-release-candidate Community feedback wanted on Lab component before it is move to production ready / core package label Sep 20, 2024
@jake-costa
Copy link

Validation of a11y changes in-progress

@origami-z
Copy link
Contributor

Some feedback from Shannon, what happens when needing to show lots of steps horizontally (when converting to vertical is not an option). Can something like breadcrumb's menu be possible to implement (not out of box behaviour, but composable)?

@ivan-calderon
Copy link
Contributor

@bhoppers2008 is the above feedback something we should prioritize for the coming sprint? James Sol recently had a similar request while working in the Pepper Stepped Tracker.

@mark-tate
Copy link
Contributor

Tom is working on remaning feedback but we should answer the question above
Galao Goal: dev complete and backlog updated with any future design tasks (@bhoppers2008)

@mark-tate
Copy link
Contributor

@tomhazledine do we have an update on this ?

@mark-tate
Copy link
Contributor

Latte: no capacity, bump to Lungo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: pepper community: core-release-candidate Community feedback wanted on Lab component before it is move to production ready / core package component: stepped tracker priority: high 😡 type: component 📦
Projects
Development

No branches or pull requests

7 participants