Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dot badge development #3787

Closed
origami-z opened this issue Jul 9, 2024 · 9 comments
Closed

Dot badge development #3787

origami-z opened this issue Jul 9, 2024 · 9 comments
Assignees
@yunjungyeh @dplsek
Labels
adopter: pepper component: badge type: component 📦

Comments

@origami-z
Copy link
Contributor

origami-z commented Jul 9, 2024 •
edited
Loading

Follow design done by #3321.

Spec: https://www.figma.com/design/nGyYwURvwapYwYUTlMXd7r/Dot-badge?node-id=1521-426&t=L2BThd8sZH3AQ9mf-1
@mark-tate
Copy link
Contributor

Goal: Dev complete by EOS
Kickoff required

@yunjungyeh yunjungyeh mentioned this issue Jul 22, 2024
Closed
@yunjungyeh
Copy link
Contributor

kick-off scheduled on Thu 25 Jul

@origami-z
Copy link
Contributor Author

origami-z commented Jul 25, 2024 •
edited
Loading

Push 1 sprint behind to Cartado due to capacity

@mark-tate
Copy link
Contributor

mark-tate commented Aug 5, 2024 •
edited
Loading

Cortado Goal:
Kickoff required
RC by EOS but if we can get Pepper feedback by EOS, possible to move to Core

@yunjungyeh yunjungyeh mentioned this issue Aug 5, 2024
Closed
@joshwooding joshwooding changed the title Notification dot badge development Dot badge development Aug 8, 2024
@yunjungyeh
Copy link
Contributor

PR #3969

@origami-z
Copy link
Contributor Author

Aug 12 - PR review comments addressed, to be re-reviewed

@joshwooding
Copy link
Contributor

Aug 14 = PR has initial review. Needs a final review by @yunjungyeh

@origami-z
Copy link
Contributor Author

Aug 16 - Needs discussion on code API.

@jpmorganchase jpmorganchase deleted a comment from javasun1000 Aug 23, 2024
@yunjungyeh
Copy link
Contributor

Updates for the feedback from Jake, @mark-tate, @joshwooding, @origami-z, @dplsek, @yunjungyeh are addressed, PR #3969 merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunjungyeh yunjungyeh

@dplsek dplsek

Labels
adopter: pepper component: badge type: component 📦
Projects
Salt - Components, Patterns and Theming
Status: Planned
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mark-tate @origami-z @joshwooding @yunjungyeh @dplsek