Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Button Bar pattern in Salt Figma #3933

Open
3 tasks
bhoppers2008 opened this issue Aug 2, 2024 · 4 comments
Open
3 tasks

Update Button Bar pattern in Salt Figma #3933

bhoppers2008 opened this issue Aug 2, 2024 · 4 comments

Comments

@bhoppers2008
Copy link

bhoppers2008 commented Aug 2, 2024

The following updates have been made to Next and need to be made to Salt Light & Dark.

Aug 2, 2024 update

Renamed components:

  • Single-step form > Horizontal
  • Dialog > Horizontal reverse
  • Small Viewport > Horizontal fill

Why? Too specific. Generalising names caters for wider use cases.

Added Horizontal fill reverse component
Updated all names so overrides persist across components when swapped
Added Secondary actions boolean to all components
Added Core 3rd button boolean to all components
Tested all new updates to ensure components behave as expected
Updated Preferences Dialog and Dialog component using Button Bar pattern
Added Dialog QA story swapping Horizontal for Stacked Button Bar
All descriptions, URLs, metadata updated

Deprecated Multi-step form and Destructive actions components
Why? Both can be achieved using Horizontal and Horizontal reverse components.
What does this mean? These components should be swapped for supported components. They will be removed in a future update.

Tasks

@yunjungyeh
Copy link
Contributor

2 Aug - Updated boolean prop name to Core 3rd button and merged the branch in Salt Next

@mark-tate
Copy link
Contributor

Cortado Goal:
Update in Salt 1 for light/dark and merge

@origami-z
Copy link
Contributor

origami-z commented Aug 12, 2024

Aug 12 - should be pushed to later sprint. Move to next sprint due to capacity.

@mark-tate
Copy link
Contributor

Sprint Goal - updated ButtonBar pattern guidance with Header can be used with Dialog & new buttons
(could be a design task or design & dev)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants