Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static list component #3975

Closed
wants to merge 45 commits into from
Closed

Conversation

ThusharaJ07
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: 1754553

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/lab Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 12, 2024

@ThusharaJ07 is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 9:42am

packages/lab/src/static-list/StaticList.css Outdated Show resolved Hide resolved
packages/lab/src/static-list/StaticListItem.css Outdated Show resolved Hide resolved
packages/lab/src/static-list/StaticListItem.css Outdated Show resolved Hide resolved
packages/lab/src/static-list/StaticListItem.css Outdated Show resolved Hide resolved
packages/lab/stories/static-list/static-list.stories.tsx Outdated Show resolved Hide resolved
@ivan-calderon
Copy link
Contributor

Sharing Design review for reference. (Currently going through 3rd round of reviews)

@ivan-calderon
Copy link
Contributor

@ThusharaJ07, please remove the "Reference", "Requirements", And "Helpful" sections from Accessibility. For now let's keep Keyboard Interactions only as we do in most of the components.Thank you!

);

export const Multiple = (): ReactElement => {
const [listArray, setListArray] = useState([ListItem, ListItem]);
Copy link
Contributor

@joshwooding joshwooding Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't representative. This example needs updating to not store the JSX in an array

</Text>
</StackLayout>
</StaticListItemContent>
<Button variant="secondary" aria-label={"icon"}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update these aria-labels in this example

$ref: ./#/data
---

<LivePreviewControls>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design guidance needs to be reviewed

@Fercas123 Fercas123 mentioned this pull request Sep 27, 2024
@Fercas123
Copy link
Contributor

Closing to carry on in the repo's duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants